ghostguild-org/app/pages
Jennie Robinson Faber 208638e374 feat(launch): security and correctness fixes for 2026-05-01 launch
Day-of-launch deep-dive audit and remediation. 11 issues fixed across
security, correctness, and reliability. Tests: 698 → 758 passing
(+60), 0 failing, 2 skipped.

CRITICAL (security)

Fix #1 — HELCIM_API_TOKEN removed from runtimeConfig.public; dead
useHelcim.js deleted. Production token MUST BE ROTATED post-deploy
(was previously exposed in window.__NUXT__ payload).

Fix #2 — /api/helcim/customer gated with origin check + per-IP/email
rate limit + magic-link email verification (replaces unauthenticated
setAuthCookie). Adds payment-bridge token for paid-tier signup so
users can complete Helcim checkout before email verify. New utils:
server/utils/{magicLink,rateLimit}.js. UX: signup success copy now
prompts user to check email.

Fix #3 — /api/events/[id]/payment deleted (dead code with unauth
member-spoof bypass — processHelcimPayment was a permanent stub).
Removes processHelcimPayment export and eventPaymentSchema.

Fix #4 — /api/helcim/initialize-payment re-derives ticket amount
server-side via calculateTicketPrice and calculateSeriesTicketPrice.
Adds new series_ticket metadata type (was being shoved through
event_ticket with seriesId in metadata.eventId).

Fix #5 — /api/helcim/customer upgrades existing status:guest members
in place rather than rejecting with 409. Lowercases email at lookup;
preserves _id so prior event registrations stay linked.

HIGH (correctness / reliability)

Fix #6 — Daily reconciliation cron via Netlify scheduled function
(@daily). New: netlify.toml, netlify/functions/reconcile-payments.mjs,
server/api/internal/reconcile-payments.post.js. Shared-secret auth
via NUXT_RECONCILE_TOKEN env var. Inline 3-retry exponential backoff
on Helcim transactions API.

Fix #7 — validateBeforeSave: false on event subdoc saves (waitlist
endpoints) to dodge legacy location validators.

Fix #8 — /api/series/[id]/tickets/purchase always upserts a guest
Member when caller is unauthenticated, mirrors event-ticket flow
byte-for-byte. SeriesPassPurchase.vue adds guest-account hint and
client auth refresh on signedIn:true response.

Fix #9 — /api/members/cancel-subscription leaves status active per
ratified bylaws (was pending_payment). Adds lastCancelledAt audit
field on Member model. Indirectly fixes false-positive
detectStuckPendingPayment admin alert for cancelled members.

Fix #10 — /api/auth/verify uses validateBody with strict() Zod schema
(verifyMagicLinkSchema, max 2000 chars).

Fix #11 — 8 vitest cases for cancel-subscription handler (was
uncovered).

Specs and audit at docs/superpowers/specs/2026-04-25-fix-*.md and
docs/superpowers/plans/2026-04-25-launch-readiness-fixes.md.
LAUNCH_READINESS.md updated with new test count, 3 deploy-time
tasks (rotate Helcim token, set NUXT_RECONCILE_TOKEN, verify
Netlify scheduled function), and Fixed-2026-04-25 fix log.
2026-04-25 18:42:36 +01:00
..
about feat: reskin public pages to zine direction 2026-04-02 21:29:52 +01:00
admin feat(emails): warmer copy across invite, welcome, and event emails 2026-04-20 13:48:38 +01:00
auth fix(auth): stop wiki login loop to coming-soon and surface non-member state 2026-04-15 17:55:55 +01:00
events chore(visual): Phase 4 audit polish on event/series surface 2026-04-25 18:41:04 +01:00
member fix(account): show payment history + next-charge for paid-then-$0 members 2026-04-20 12:36:18 +01:00
members Copy and layout improvements. 2026-04-16 21:11:05 +01:00
policies feat(events): block self-cancel of paid registrations, add refunds policy 2026-04-20 19:34:04 +01:00
series chore(visual): Phase 4 audit polish on event/series surface 2026-04-25 18:41:04 +01:00
about.vue Member/Ecology revamp. 2026-04-14 09:25:09 +01:00
accept-invite.vue feat(signup): unify cadence UX across accept-invite, join, and account 2026-04-20 12:34:59 +01:00
board.vue Copy and layout improvements. 2026-04-16 21:11:05 +01:00
coming-soon.vue Member/Ecology revamp. 2026-04-14 09:25:09 +01:00
community-guidelines.vue feat(signup): community guidelines agreement and policies routes 2026-04-18 17:06:10 +01:00
connections.vue Rename communityEcology → board across frontend, add Board nav, update redirects 2026-04-14 12:15:51 +01:00
ecology.vue Rename communityEcology → board across frontend, add Board nav, update redirects 2026-04-14 12:15:51 +01:00
index.vue Copy and layout improvements. 2026-04-16 21:11:05 +01:00
join.vue feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
login.vue Add login form to coming-soon page and allow admin routes through 2026-03-19 11:01:03 +00:00
verify.vue fix: use private helcimApiToken for all server-side Helcim API calls 2026-04-04 13:37:34 +01:00
welcome.vue feat(signup): unify cadence UX across accept-invite, join, and account 2026-04-20 12:34:59 +01:00