jennie/ghostguild-org
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(admin): drive members status <select>s from STATUS_LABELS

Browse source 
The status options were duplicated three times in admin/members/index.vue
(filter dropdown, edit-modal dropdown, statusLabel helper). The recent
"Pending Payment" → "Payment setup incomplete" rename only landed in
two of the three sites. Both <select>s now v-for over the existing
STATUS_LABELS const, so any future label change happens in one place.

Side effect: the edit-modal dropdown order is now
(active, pending_payment, suspended, cancelled) to match the filter
dropdown — was previously pending_payment-first.
This commit is contained in:
Jennie Robinson Faber 2026-04-30 15:28:36 +01:00
parent d9444b022b
commit 441a5f5608
1 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
app/pages/admin/members/index.vue
View file

@ -41,10 +41,11 @@
<div class="field" style="margin-bottom: 0">
<select v-model="statusFilter" aria-label="Filter by status">
<option value="">All Statuses</option>
<option value="active">Active</option>
<option value="pending_payment">Payment setup incomplete</option>
<option value="suspended">Suspended</option>
<option value="cancelled">Cancelled</option>
<option
v-for="(label, value) in STATUS_LABELS"
:key="value"
:value="value"
>{{ label }}</option>
</select>
</div>
</div>
@ -371,10 +372,11 @@
<div class="field">
<label>Status</label>
<select v-model="editingMember.status">
<option value="pending_payment">Payment setup incomplete</option>
<option value="active">Active</option>
<option value="suspended">Suspended</option>
<option value="cancelled">Cancelled</option>
<option
v-for="(label, value) in STATUS_LABELS"
:key="value"
:value="value"
>{{ label }}</option>
</select>
</div>
<div class="modal-actions">