From 441a5f5608abed1aa7e7298a31b29d6df9bc018e Mon Sep 17 00:00:00 2001
From: Jennie Robinson Faber <jennie@jenniefaber.com>
Date: Thu, 30 Apr 2026 15:28:36 +0100
Subject: [PATCH] refactor(admin): drive members status <select>s from
 STATUS_LABELS
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The status options were duplicated three times in admin/members/index.vue
(filter dropdown, edit-modal dropdown, statusLabel helper). The recent
"Pending Payment" → "Payment setup incomplete" rename only landed in
two of the three sites. Both <select>s now v-for over the existing
STATUS_LABELS const, so any future label change happens in one place.

Side effect: the edit-modal dropdown order is now
(active, pending_payment, suspended, cancelled) to match the filter
dropdown — was previously pending_payment-first.
---
 app/pages/admin/members/index.vue | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/app/pages/admin/members/index.vue b/app/pages/admin/members/index.vue
index bce22e1..88f28b5 100644
--- a/app/pages/admin/members/index.vue
+++ b/app/pages/admin/members/index.vue
@@ -41,10 +41,11 @@
       <div class="field" style="margin-bottom: 0">
         <select v-model="statusFilter" aria-label="Filter by status">
           <option value="">All Statuses</option>
-          <option value="active">Active</option>
-          <option value="pending_payment">Payment setup incomplete</option>
-          <option value="suspended">Suspended</option>
-          <option value="cancelled">Cancelled</option>
+          <option
+            v-for="(label, value) in STATUS_LABELS"
+            :key="value"
+            :value="value"
+          >{{ label }}</option>
         </select>
       </div>
     </div>
@@ -371,10 +372,11 @@
           <div class="field">
             <label>Status</label>
             <select v-model="editingMember.status">
-              <option value="pending_payment">Payment setup incomplete</option>
-              <option value="active">Active</option>
-              <option value="suspended">Suspended</option>
-              <option value="cancelled">Cancelled</option>
+              <option
+                v-for="(label, value) in STATUS_LABELS"
+                :key="value"
+                :value="value"
+              >{{ label }}</option>
             </select>
           </div>
           <div class="modal-actions">