Jennie Robinson Faber
51230e5151
Follow-up to 208638e. Code review surfaced a few real issues; this
commit addresses them.
- login.post.js now uses the new sendMagicLink util instead of
duplicating the jti/jwt/Resend/logActivity logic. Reduces 60 lines.
- sendMagicLink accepts an optional pre-loaded Member doc, skipping
the redundant findOne when the caller already has one. customer.post.js
passes the just-created/upgraded member, dropping signup from 3
Mongo round-trips to 1 (lookup is gone; jti burn remains).
- sendMagicLink now lowercases the email defensively so callers don't
have to remember.
- rateLimit.js: replaced an effectively-dead eviction line with a
probabilistic sweep (~1% of calls scan and evict keys whose newest
entry has aged out). Caps unbounded Map growth under random-key
spraying.
- reconcile-payments.post.js: 401/403/404 from Helcim now bails out
immediately instead of burning all 3 retry attempts; dry-run
summary filters via the same RECONCILABLE_STATUSES set as apply
mode so counts match.
- Deleted WHAT-comments and section banners per CLAUDE.md no-comment
rule. Kept genuine WHY-comments (validateBeforeSave rationale,
amount-IGNORED-for-tickets, sendConfirmation deliberately-omitted).
Tests: 758/760 passing (unchanged).
68 lines
2.2 KiB
JavaScript
68 lines
2.2 KiB
JavaScript
// Send a magic-link verification email. Mirrors the token/email logic in
|
|
// server/api/auth/login.post.js so callers (signup, login, etc.) can request
|
|
// a verification link with their own subject/intro copy.
|
|
import jwt from 'jsonwebtoken'
|
|
import { randomUUID } from 'crypto'
|
|
import { Resend } from 'resend'
|
|
import Member from '../models/member.js'
|
|
|
|
const resend = new Resend(process.env.RESEND_API_KEY)
|
|
|
|
/**
|
|
* Issue a 15-minute magic-link JWT for `email` and email it.
|
|
*
|
|
* @param {string} email
|
|
* @param {object} [options]
|
|
* @param {string} [options.subject] - Email subject (default: "Your Ghost Guild login link")
|
|
* @param {string} [options.intro] - Optional one-line intro before the link.
|
|
* @param {object} [options.member] - Pre-loaded Member doc; skips the findOne lookup.
|
|
* @returns {Promise<{ sent: boolean }>} - sent=false when no member exists for the email
|
|
* (caller can decide whether to surface that; the auth/login endpoint hides it for
|
|
* anti-enumeration, signup knows the member was just created).
|
|
*/
|
|
export async function sendMagicLink(email, options = {}) {
|
|
const baseUrl = process.env.BASE_URL
|
|
if (!baseUrl) {
|
|
throw createError({
|
|
statusCode: 500,
|
|
statusMessage: 'BASE_URL environment variable is not set'
|
|
})
|
|
}
|
|
|
|
email = email.toLowerCase()
|
|
const member = options.member || await Member.findOne({ email })
|
|
if (!member) return { sent: false }
|
|
|
|
const jti = randomUUID()
|
|
const token = jwt.sign(
|
|
{ memberId: member._id, jti },
|
|
useRuntimeConfig().jwtSecret,
|
|
{ expiresIn: '15m' }
|
|
)
|
|
|
|
await Member.findByIdAndUpdate(
|
|
member._id,
|
|
{ $set: { magicLinkJti: jti, magicLinkJtiUsed: false } },
|
|
{ runValidators: false }
|
|
)
|
|
|
|
const magicLink = `${baseUrl}/verify#${token}`
|
|
const subject = options.subject || 'Your Ghost Guild login link'
|
|
const intro = options.intro || 'Sign in to Ghost Guild:'
|
|
const text = `Hi,\n\n${intro}\n${magicLink}\n\nThis link expires in 15 minutes. If you didn't request it, ignore this email.`
|
|
|
|
await resend.emails.send({
|
|
from: 'Ghost Guild <ghostguild@babyghosts.org>',
|
|
to: email,
|
|
subject,
|
|
text
|
|
})
|
|
|
|
logActivity(member._id, 'email_sent', {
|
|
emailType: 'magic_link',
|
|
subject,
|
|
body: text
|
|
})
|
|
|
|
return { sent: true }
|
|
}
|