Jennie Robinson Faber
208638e374
Day-of-launch deep-dive audit and remediation. 11 issues fixed across security, correctness, and reliability. Tests: 698 → 758 passing (+60), 0 failing, 2 skipped. CRITICAL (security) Fix #1 — HELCIM_API_TOKEN removed from runtimeConfig.public; dead useHelcim.js deleted. Production token MUST BE ROTATED post-deploy (was previously exposed in window.__NUXT__ payload). Fix #2 — /api/helcim/customer gated with origin check + per-IP/email rate limit + magic-link email verification (replaces unauthenticated setAuthCookie). Adds payment-bridge token for paid-tier signup so users can complete Helcim checkout before email verify. New utils: server/utils/{magicLink,rateLimit}.js. UX: signup success copy now prompts user to check email. Fix #3 — /api/events/[id]/payment deleted (dead code with unauth member-spoof bypass — processHelcimPayment was a permanent stub). Removes processHelcimPayment export and eventPaymentSchema. Fix #4 — /api/helcim/initialize-payment re-derives ticket amount server-side via calculateTicketPrice and calculateSeriesTicketPrice. Adds new series_ticket metadata type (was being shoved through event_ticket with seriesId in metadata.eventId). Fix #5 — /api/helcim/customer upgrades existing status:guest members in place rather than rejecting with 409. Lowercases email at lookup; preserves _id so prior event registrations stay linked. HIGH (correctness / reliability) Fix #6 — Daily reconciliation cron via Netlify scheduled function (@daily). New: netlify.toml, netlify/functions/reconcile-payments.mjs, server/api/internal/reconcile-payments.post.js. Shared-secret auth via NUXT_RECONCILE_TOKEN env var. Inline 3-retry exponential backoff on Helcim transactions API. Fix #7 — validateBeforeSave: false on event subdoc saves (waitlist endpoints) to dodge legacy location validators. Fix #8 — /api/series/[id]/tickets/purchase always upserts a guest Member when caller is unauthenticated, mirrors event-ticket flow byte-for-byte. SeriesPassPurchase.vue adds guest-account hint and client auth refresh on signedIn:true response. Fix #9 — /api/members/cancel-subscription leaves status active per ratified bylaws (was pending_payment). Adds lastCancelledAt audit field on Member model. Indirectly fixes false-positive detectStuckPendingPayment admin alert for cancelled members. Fix #10 — /api/auth/verify uses validateBody with strict() Zod schema (verifyMagicLinkSchema, max 2000 chars). Fix #11 — 8 vitest cases for cancel-subscription handler (was uncovered). Specs and audit at docs/superpowers/specs/2026-04-25-fix-*.md and docs/superpowers/plans/2026-04-25-launch-readiness-fixes.md. LAUNCH_READINESS.md updated with new test count, 3 deploy-time tasks (rotate Helcim token, set NUXT_RECONCILE_TOKEN, verify Netlify scheduled function), and Fixed-2026-04-25 fix log.
49 lines
1.8 KiB
JavaScript
49 lines
1.8 KiB
JavaScript
import { describe, it, expect } from 'vitest'
|
|
import { readFileSync, existsSync } from 'node:fs'
|
|
import { resolve } from 'node:path'
|
|
|
|
const eventsDir = resolve(import.meta.dirname, '../../../server/api/events/[id]')
|
|
|
|
describe('waitlist.post.js bypasses validators on event.save()', () => {
|
|
const source = readFileSync(resolve(eventsDir, 'waitlist.post.js'), 'utf-8')
|
|
|
|
it('calls eventData.save with validateBeforeSave: false', () => {
|
|
expect(source).toContain('eventData.save({ validateBeforeSave: false })')
|
|
})
|
|
|
|
it('does not contain a bare eventData.save() call', () => {
|
|
expect(source).not.toMatch(/eventData\.save\(\s*\)/)
|
|
})
|
|
})
|
|
|
|
describe('waitlist.delete.js bypasses validators on event.save()', () => {
|
|
const source = readFileSync(resolve(eventsDir, 'waitlist.delete.js'), 'utf-8')
|
|
|
|
it('calls eventData.save with validateBeforeSave: false', () => {
|
|
expect(source).toContain('eventData.save({ validateBeforeSave: false })')
|
|
})
|
|
|
|
it('does not contain a bare eventData.save() call', () => {
|
|
expect(source).not.toMatch(/eventData\.save\(\s*\)/)
|
|
})
|
|
})
|
|
|
|
// payment.post.js cases are handled by Fix #3 (file deletion).
|
|
// If the file still exists, it should also pass the validators bypass.
|
|
describe.skipIf(!existsSync(resolve(eventsDir, 'payment.post.js')))(
|
|
'payment.post.js bypasses validators on event.save()',
|
|
() => {
|
|
const source = existsSync(resolve(eventsDir, 'payment.post.js'))
|
|
? readFileSync(resolve(eventsDir, 'payment.post.js'), 'utf-8')
|
|
: ''
|
|
|
|
it('has exactly two eventData.save({ validateBeforeSave: false }) calls', () => {
|
|
const matches = source.match(/eventData\.save\(\{\s*validateBeforeSave:\s*false\s*\}\)/g) || []
|
|
expect(matches.length).toBe(2)
|
|
})
|
|
|
|
it('does not contain a bare eventData.save() call', () => {
|
|
expect(source).not.toMatch(/eventData\.save\(\s*\)/)
|
|
})
|
|
}
|
|
)
|