Jennie Robinson Faber
0f841912e2
Helcim refuses paymentType:'verify' for cards already saved on a
customer ("A new card must be entered for saving the payment method"),
breaking every "Complete Payment" retry after a partial-failed signup.
Add GET /api/helcim/existing-card and short-circuit HelcimPay verify in
useMemberPayment + payment-setup.vue when a saved card is found, going
straight to subscription creation. The two existence-check fetches run
in parallel with get-or-create-customer so no extra round-trip latency
in the common path.
115 lines
3.8 KiB
JavaScript
115 lines
3.8 KiB
JavaScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
import { requireAuth } from '../../../server/utils/auth.js'
|
|
import { listHelcimCustomerCards } from '../../../server/utils/helcim.js'
|
|
import existingCardHandler from '../../../server/api/helcim/existing-card.get.js'
|
|
import { createMockEvent } from '../helpers/createMockEvent.js'
|
|
|
|
vi.mock('../../../server/utils/auth.js', () => ({ requireAuth: vi.fn() }))
|
|
vi.mock('../../../server/utils/helcim.js', () => ({
|
|
listHelcimCustomerCards: vi.fn()
|
|
}))
|
|
|
|
const newEvent = () =>
|
|
createMockEvent({ method: 'GET', path: '/api/helcim/existing-card' })
|
|
|
|
describe('helcim existing-card endpoint', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
it('requires auth', async () => {
|
|
requireAuth.mockRejectedValue(
|
|
createError({ statusCode: 401, statusMessage: 'Unauthorized' })
|
|
)
|
|
|
|
await expect(existingCardHandler(newEvent())).rejects.toMatchObject({ statusCode: 401 })
|
|
expect(listHelcimCustomerCards).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('returns { cardToken: null } when member has no helcimCustomerId', async () => {
|
|
requireAuth.mockResolvedValue({ _id: 'm1', helcimCustomerId: null })
|
|
|
|
const result = await existingCardHandler(newEvent())
|
|
|
|
expect(result).toEqual({ cardToken: null })
|
|
expect(listHelcimCustomerCards).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('returns { cardToken: null } when customer has no cards', async () => {
|
|
requireAuth.mockResolvedValue({ _id: 'm1', helcimCustomerId: 9876 })
|
|
listHelcimCustomerCards.mockResolvedValue([])
|
|
|
|
const result = await existingCardHandler(newEvent())
|
|
|
|
expect(result).toEqual({ cardToken: null })
|
|
expect(listHelcimCustomerCards).toHaveBeenCalledWith(9876)
|
|
})
|
|
|
|
it('returns the default card when one is flagged default:true', async () => {
|
|
requireAuth.mockResolvedValue({ _id: 'm1', helcimCustomerId: 9876 })
|
|
listHelcimCustomerCards.mockResolvedValue([
|
|
{ cardToken: 'tok-old' },
|
|
{ cardToken: 'tok-default', default: true }
|
|
])
|
|
|
|
const result = await existingCardHandler(newEvent())
|
|
|
|
expect(result).toEqual({ cardToken: 'tok-default' })
|
|
})
|
|
|
|
it('falls back to first card when no card is flagged default', async () => {
|
|
requireAuth.mockResolvedValue({ _id: 'm1', helcimCustomerId: 9876 })
|
|
listHelcimCustomerCards.mockResolvedValue([
|
|
{ cardToken: 'tok-first' },
|
|
{ cardToken: 'tok-second' }
|
|
])
|
|
|
|
const result = await existingCardHandler(newEvent())
|
|
|
|
expect(result).toEqual({ cardToken: 'tok-first' })
|
|
})
|
|
|
|
it('handles isDefault flag (alternative shape)', async () => {
|
|
requireAuth.mockResolvedValue({ _id: 'm1', helcimCustomerId: 9876 })
|
|
listHelcimCustomerCards.mockResolvedValue([
|
|
{ cardToken: 'tok-a' },
|
|
{ cardToken: 'tok-b', isDefault: true }
|
|
])
|
|
|
|
const result = await existingCardHandler(newEvent())
|
|
|
|
expect(result.cardToken).toBe('tok-b')
|
|
})
|
|
|
|
it('unwraps a { cards: [...] } response envelope', async () => {
|
|
requireAuth.mockResolvedValue({ _id: 'm1', helcimCustomerId: 9876 })
|
|
listHelcimCustomerCards.mockResolvedValue({
|
|
cards: [{ cardToken: 'tok-only' }]
|
|
})
|
|
|
|
const result = await existingCardHandler(newEvent())
|
|
|
|
expect(result.cardToken).toBe('tok-only')
|
|
})
|
|
|
|
it('unwraps a { data: [...] } response envelope', async () => {
|
|
requireAuth.mockResolvedValue({ _id: 'm1', helcimCustomerId: 9876 })
|
|
listHelcimCustomerCards.mockResolvedValue({
|
|
data: [{ cardToken: 'tok-only' }]
|
|
})
|
|
|
|
const result = await existingCardHandler(newEvent())
|
|
|
|
expect(result.cardToken).toBe('tok-only')
|
|
})
|
|
|
|
it('returns { cardToken: null } if the resolved card has no cardToken', async () => {
|
|
requireAuth.mockResolvedValue({ _id: 'm1', helcimCustomerId: 9876 })
|
|
listHelcimCustomerCards.mockResolvedValue([{ default: true }])
|
|
|
|
const result = await existingCardHandler(newEvent())
|
|
|
|
expect(result).toEqual({ cardToken: null })
|
|
})
|
|
})
|