ghostguild-org/server/api/events/[id]/waitlist.post.js
Jennie Robinson Faber 208638e374 feat(launch): security and correctness fixes for 2026-05-01 launch
Day-of-launch deep-dive audit and remediation. 11 issues fixed across
security, correctness, and reliability. Tests: 698 → 758 passing
(+60), 0 failing, 2 skipped.

CRITICAL (security)

Fix #1 — HELCIM_API_TOKEN removed from runtimeConfig.public; dead
useHelcim.js deleted. Production token MUST BE ROTATED post-deploy
(was previously exposed in window.__NUXT__ payload).

Fix #2 — /api/helcim/customer gated with origin check + per-IP/email
rate limit + magic-link email verification (replaces unauthenticated
setAuthCookie). Adds payment-bridge token for paid-tier signup so
users can complete Helcim checkout before email verify. New utils:
server/utils/{magicLink,rateLimit}.js. UX: signup success copy now
prompts user to check email.

Fix #3 — /api/events/[id]/payment deleted (dead code with unauth
member-spoof bypass — processHelcimPayment was a permanent stub).
Removes processHelcimPayment export and eventPaymentSchema.

Fix #4 — /api/helcim/initialize-payment re-derives ticket amount
server-side via calculateTicketPrice and calculateSeriesTicketPrice.
Adds new series_ticket metadata type (was being shoved through
event_ticket with seriesId in metadata.eventId).

Fix #5 — /api/helcim/customer upgrades existing status:guest members
in place rather than rejecting with 409. Lowercases email at lookup;
preserves _id so prior event registrations stay linked.

HIGH (correctness / reliability)

Fix #6 — Daily reconciliation cron via Netlify scheduled function
(@daily). New: netlify.toml, netlify/functions/reconcile-payments.mjs,
server/api/internal/reconcile-payments.post.js. Shared-secret auth
via NUXT_RECONCILE_TOKEN env var. Inline 3-retry exponential backoff
on Helcim transactions API.

Fix #7 — validateBeforeSave: false on event subdoc saves (waitlist
endpoints) to dodge legacy location validators.

Fix #8 — /api/series/[id]/tickets/purchase always upserts a guest
Member when caller is unauthenticated, mirrors event-ticket flow
byte-for-byte. SeriesPassPurchase.vue adds guest-account hint and
client auth refresh on signedIn:true response.

Fix #9 — /api/members/cancel-subscription leaves status active per
ratified bylaws (was pending_payment). Adds lastCancelledAt audit
field on Member model. Indirectly fixes false-positive
detectStuckPendingPayment admin alert for cancelled members.

Fix #10 — /api/auth/verify uses validateBody with strict() Zod schema
(verifyMagicLinkSchema, max 2000 chars).

Fix #11 — 8 vitest cases for cancel-subscription handler (was
uncovered).

Specs and audit at docs/superpowers/specs/2026-04-25-fix-*.md and
docs/superpowers/plans/2026-04-25-launch-readiness-fixes.md.
LAUNCH_READINESS.md updated with new test count, 3 deploy-time
tasks (rotate Helcim token, set NUXT_RECONCILE_TOKEN, verify
Netlify scheduled function), and Fixed-2026-04-25 fix log.
2026-04-25 18:42:36 +01:00

113 lines
3.1 KiB
JavaScript

import Event from "../../../models/event";
import Member from "../../../models/member";
export default defineEventHandler(async (event) => {
const id = getRouterParam(event, "id");
const body = await validateBody(event, waitlistSchema);
const { name, email, membershipLevel } = body;
try {
// Find event by ID or slug
const eventData = await Event.findOne({
$or: [{ _id: id }, { slug: id }],
});
if (!eventData) {
throw createError({
statusCode: 404,
statusMessage: "Event not found",
});
}
// Check if waitlist is enabled
if (!eventData.tickets?.waitlist?.enabled) {
throw createError({
statusCode: 400,
statusMessage: "Waitlist is not enabled for this event",
});
}
// Check if already on waitlist
const existingEntry = eventData.tickets.waitlist.entries?.find(
(entry) => entry.email.toLowerCase() === email.toLowerCase()
);
if (existingEntry) {
throw createError({
statusCode: 400,
statusMessage: "You are already on the waitlist for this event",
});
}
// Check if already registered
const existingRegistration = eventData.registrations?.find(
(reg) => reg.email?.toLowerCase() === email.toLowerCase() && !reg.cancelledAt
);
if (existingRegistration) {
throw createError({
statusCode: 400,
statusMessage: "You are already registered for this event",
});
}
// Check waitlist capacity
const currentWaitlistSize = eventData.tickets.waitlist.entries?.length || 0;
const maxSize = eventData.tickets.waitlist.maxSize;
if (maxSize && currentWaitlistSize >= maxSize) {
throw createError({
statusCode: 400,
statusMessage: "The waitlist is full",
});
}
// Get member info if authenticated
let memberName = name;
let memberLevel = membershipLevel || "non-member";
// Try to find member by email
const member = await Member.findOne({ email: email.toLowerCase() });
if (member) {
memberName = memberName || member.name;
memberLevel = `${member.circle}-${member.contributionAmount}`;
}
// Add to waitlist
if (!eventData.tickets.waitlist.entries) {
eventData.tickets.waitlist.entries = [];
}
eventData.tickets.waitlist.entries.push({
name: memberName || "Guest",
email: email.toLowerCase(),
membershipLevel: memberLevel,
addedAt: new Date(),
notified: false,
});
// Skip validators to avoid tripping on legacy location data unrelated to this write.
await eventData.save({ validateBeforeSave: false });
// Get position in waitlist
const position = eventData.tickets.waitlist.entries.length;
return {
success: true,
message: "You have been added to the waitlist",
position,
totalWaitlisted: position,
};
} catch (error) {
if (error.statusCode) {
throw error;
}
console.error("Error joining waitlist:", error);
throw createError({
statusCode: 500,
statusMessage: "Failed to join waitlist",
});
}
});