Day-of-launch deep-dive audit and remediation. 11 issues fixed across security, correctness, and reliability. Tests: 698 → 758 passing (+60), 0 failing, 2 skipped. CRITICAL (security) Fix #1 — HELCIM_API_TOKEN removed from runtimeConfig.public; dead useHelcim.js deleted. Production token MUST BE ROTATED post-deploy (was previously exposed in window.__NUXT__ payload). Fix #2 — /api/helcim/customer gated with origin check + per-IP/email rate limit + magic-link email verification (replaces unauthenticated setAuthCookie). Adds payment-bridge token for paid-tier signup so users can complete Helcim checkout before email verify. New utils: server/utils/{magicLink,rateLimit}.js. UX: signup success copy now prompts user to check email. Fix #3 — /api/events/[id]/payment deleted (dead code with unauth member-spoof bypass — processHelcimPayment was a permanent stub). Removes processHelcimPayment export and eventPaymentSchema. Fix #4 — /api/helcim/initialize-payment re-derives ticket amount server-side via calculateTicketPrice and calculateSeriesTicketPrice. Adds new series_ticket metadata type (was being shoved through event_ticket with seriesId in metadata.eventId). Fix #5 — /api/helcim/customer upgrades existing status:guest members in place rather than rejecting with 409. Lowercases email at lookup; preserves _id so prior event registrations stay linked. HIGH (correctness / reliability) Fix #6 — Daily reconciliation cron via Netlify scheduled function (@daily). New: netlify.toml, netlify/functions/reconcile-payments.mjs, server/api/internal/reconcile-payments.post.js. Shared-secret auth via NUXT_RECONCILE_TOKEN env var. Inline 3-retry exponential backoff on Helcim transactions API. Fix #7 — validateBeforeSave: false on event subdoc saves (waitlist endpoints) to dodge legacy location validators. Fix #8 — /api/series/[id]/tickets/purchase always upserts a guest Member when caller is unauthenticated, mirrors event-ticket flow byte-for-byte. SeriesPassPurchase.vue adds guest-account hint and client auth refresh on signedIn:true response. Fix #9 — /api/members/cancel-subscription leaves status active per ratified bylaws (was pending_payment). Adds lastCancelledAt audit field on Member model. Indirectly fixes false-positive detectStuckPendingPayment admin alert for cancelled members. Fix #10 — /api/auth/verify uses validateBody with strict() Zod schema (verifyMagicLinkSchema, max 2000 chars). Fix #11 — 8 vitest cases for cancel-subscription handler (was uncovered). Specs and audit at docs/superpowers/specs/2026-04-25-fix-*.md and docs/superpowers/plans/2026-04-25-launch-readiness-fixes.md. LAUNCH_READINESS.md updated with new test count, 3 deploy-time tasks (rotate Helcim token, set NUXT_RECONCILE_TOKEN, verify Netlify scheduled function), and Fixed-2026-04-25 fix log.
60 lines
1.7 KiB
JavaScript
60 lines
1.7 KiB
JavaScript
// Cancel member subscription
|
|
import Member from "../../models/member.js";
|
|
import { cancelHelcimSubscription } from "../../utils/helcim.js";
|
|
|
|
export default defineEventHandler(async (event) => {
|
|
try {
|
|
const member = await requireAuth(event);
|
|
|
|
// If already on free tier, nothing to cancel
|
|
if (member.contributionAmount === 0 || !member.helcimSubscriptionId) {
|
|
return {
|
|
success: true,
|
|
message: "No active subscription to cancel",
|
|
status: member.status,
|
|
contributionAmount: member.contributionAmount,
|
|
};
|
|
}
|
|
|
|
try {
|
|
await cancelHelcimSubscription(member.helcimSubscriptionId);
|
|
} catch (cancelError) {
|
|
console.error("Error canceling Helcim subscription:", cancelError);
|
|
// Continue anyway - we'll update the member record
|
|
}
|
|
|
|
// Update member: drop to free tier (status stays 'active' — they're still a member)
|
|
await Member.findByIdAndUpdate(
|
|
member._id,
|
|
{
|
|
$set: {
|
|
status: 'active',
|
|
contributionAmount: 0,
|
|
helcimSubscriptionId: null,
|
|
paymentMethod: 'none',
|
|
subscriptionEndDate: new Date(),
|
|
lastCancelledAt: new Date(),
|
|
},
|
|
$unset: { nextBillingDate: 1 },
|
|
},
|
|
{ runValidators: false }
|
|
);
|
|
|
|
logActivity(member._id, 'subscription_cancelled', {
|
|
effectiveDate: new Date().toISOString()
|
|
})
|
|
|
|
return {
|
|
success: true,
|
|
message: "Subscription cancelled successfully",
|
|
status: 'active',
|
|
contributionAmount: 0,
|
|
};
|
|
} catch (error) {
|
|
console.error("Error cancelling subscription:", error);
|
|
throw createError({
|
|
statusCode: error.statusCode || 500,
|
|
statusMessage: error.message || "Failed to cancel subscription",
|
|
});
|
|
}
|
|
});
|