Jennie Robinson Faber
4d44e7045c
Main's middleware-level auth limiter (5 req / 5 min, IP-only) duplicated
the handler-level limiter introduced earlier on this branch (5/hr IP +
3/hr per-email, blocks email enumeration across IPs). Drop the
middleware version and let the handlers own it.
Added ALLOW_DEV_TEST_ENDPOINTS bypass to the rateLimit utility so
parallel E2E runs from 127.0.0.1 don't exhaust per-IP/email budgets,
mirroring the existing middleware bypass.
Trimmed the obsolete middleware auth test; handler-level coverage lives
in tests/server/api/auth-{login,verify}.test.js. Switched IP-isolation
test to the payment path so it still exercises the limiter.
69 lines
2.1 KiB
JavaScript
69 lines
2.1 KiB
JavaScript
import { describe, it, expect, beforeEach, vi } from 'vitest'
|
|
import { createMockEvent } from '../helpers/createMockEvent.js'
|
|
|
|
describe('rate-limit middleware', () => {
|
|
// Fresh import per describe block to get fresh limiter instances
|
|
let rateLimitMiddleware
|
|
|
|
beforeEach(async () => {
|
|
vi.resetModules()
|
|
const mod = await import('../../../server/middleware/03.rate-limit.js')
|
|
rateLimitMiddleware = mod.default
|
|
})
|
|
|
|
describe('non-API paths', () => {
|
|
it('skips rate limiting for non-/api/ paths', async () => {
|
|
const event = createMockEvent({ path: '/about', remoteAddress: '10.0.0.1' })
|
|
await expect(rateLimitMiddleware(event)).resolves.toBeUndefined()
|
|
})
|
|
})
|
|
|
|
describe('payment endpoint limiting (10 per min)', () => {
|
|
it('allows 10 requests then blocks the 11th', async () => {
|
|
const ip = '10.0.2.1'
|
|
|
|
for (let i = 0; i < 10; i++) {
|
|
const event = createMockEvent({
|
|
method: 'POST',
|
|
path: '/api/helcim/initialize-payment',
|
|
remoteAddress: ip
|
|
})
|
|
await expect(rateLimitMiddleware(event)).resolves.toBeUndefined()
|
|
}
|
|
|
|
const event = createMockEvent({
|
|
method: 'POST',
|
|
path: '/api/helcim/initialize-payment',
|
|
remoteAddress: ip
|
|
})
|
|
await expect(rateLimitMiddleware(event)).rejects.toMatchObject({
|
|
statusCode: 429
|
|
})
|
|
|
|
// Check Retry-After header was set
|
|
expect(event._testSetHeaders['retry-after']).toBeDefined()
|
|
})
|
|
})
|
|
|
|
describe('IP isolation', () => {
|
|
it('different IPs have separate rate limit counters', async () => {
|
|
// Exhaust payment limit for IP A
|
|
for (let i = 0; i < 10; i++) {
|
|
const event = createMockEvent({
|
|
method: 'POST',
|
|
path: '/api/helcim/initialize-payment',
|
|
remoteAddress: '10.0.3.1'
|
|
})
|
|
await rateLimitMiddleware(event)
|
|
}
|
|
|
|
// IP B should still be able to make requests
|
|
const event = createMockEvent({
|
|
method: 'POST',
|
|
path: '/api/helcim/initialize-payment',
|
|
remoteAddress: '10.0.3.2'
|
|
})
|
|
await expect(rateLimitMiddleware(event)).resolves.toBeUndefined()
|
|
})
|
|
})
|
|
})
|