ghostguild-org/tests/server/api
Jennie Robinson Faber 208638e374 feat(launch): security and correctness fixes for 2026-05-01 launch
Day-of-launch deep-dive audit and remediation. 11 issues fixed across
security, correctness, and reliability. Tests: 698 → 758 passing
(+60), 0 failing, 2 skipped.

CRITICAL (security)

Fix #1 — HELCIM_API_TOKEN removed from runtimeConfig.public; dead
useHelcim.js deleted. Production token MUST BE ROTATED post-deploy
(was previously exposed in window.__NUXT__ payload).

Fix #2 — /api/helcim/customer gated with origin check + per-IP/email
rate limit + magic-link email verification (replaces unauthenticated
setAuthCookie). Adds payment-bridge token for paid-tier signup so
users can complete Helcim checkout before email verify. New utils:
server/utils/{magicLink,rateLimit}.js. UX: signup success copy now
prompts user to check email.

Fix #3 — /api/events/[id]/payment deleted (dead code with unauth
member-spoof bypass — processHelcimPayment was a permanent stub).
Removes processHelcimPayment export and eventPaymentSchema.

Fix #4 — /api/helcim/initialize-payment re-derives ticket amount
server-side via calculateTicketPrice and calculateSeriesTicketPrice.
Adds new series_ticket metadata type (was being shoved through
event_ticket with seriesId in metadata.eventId).

Fix #5 — /api/helcim/customer upgrades existing status:guest members
in place rather than rejecting with 409. Lowercases email at lookup;
preserves _id so prior event registrations stay linked.

HIGH (correctness / reliability)

Fix #6 — Daily reconciliation cron via Netlify scheduled function
(@daily). New: netlify.toml, netlify/functions/reconcile-payments.mjs,
server/api/internal/reconcile-payments.post.js. Shared-secret auth
via NUXT_RECONCILE_TOKEN env var. Inline 3-retry exponential backoff
on Helcim transactions API.

Fix #7 — validateBeforeSave: false on event subdoc saves (waitlist
endpoints) to dodge legacy location validators.

Fix #8 — /api/series/[id]/tickets/purchase always upserts a guest
Member when caller is unauthenticated, mirrors event-ticket flow
byte-for-byte. SeriesPassPurchase.vue adds guest-account hint and
client auth refresh on signedIn:true response.

Fix #9 — /api/members/cancel-subscription leaves status active per
ratified bylaws (was pending_payment). Adds lastCancelledAt audit
field on Member model. Indirectly fixes false-positive
detectStuckPendingPayment admin alert for cancelled members.

Fix #10 — /api/auth/verify uses validateBody with strict() Zod schema
(verifyMagicLinkSchema, max 2000 chars).

Fix #11 — 8 vitest cases for cancel-subscription handler (was
uncovered).

Specs and audit at docs/superpowers/specs/2026-04-25-fix-*.md and
docs/superpowers/plans/2026-04-25-launch-readiness-fixes.md.
LAUNCH_READINESS.md updated with new test count, 3 deploy-time
tasks (rotate Helcim token, set NUXT_RECONCILE_TOKEN, verify
Netlify scheduled function), and Fixed-2026-04-25 fix log.
2026-04-25 18:42:36 +01:00
..
events feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
admin-alerts.test.js feat(admin): add restore dismissed alerts flow 2026-04-08 12:22:35 +01:00
admin-auth-guards.test.js feat(wiki): add Outline utility and wiki sync API 2026-04-09 22:33:06 +01:00
admin-role-patch.test.js Tests, UX improvements. 2026-04-05 14:25:29 +01:00
admin-wiki.test.js feat(wiki): add admin wiki management API routes 2026-04-09 22:36:44 +01:00
auth-login.test.js feat: add testing infrastructure — Vitest, Playwright, CI, git hooks 2026-04-04 16:07:21 +01:00
auth-verify.test.js feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
board-channels.test.js test: align board-channels and wiki-sync mocks with current source 2026-04-17 09:50:50 +01:00
board-posts.test.js refactor(board): atomic delete + query limit + composable cleanup 2026-04-15 12:47:53 +01:00
cancel-subscription.test.js feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
dev-endpoints.test.js merge: worktree-a11y-fixes into main 2026-04-05 22:05:00 +01:00
event-registration.test.js fix(events): enforce series-pass, hidden, and deadline gates 2026-04-20 19:03:34 +01:00
event-save-validators.test.js feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
event-tags.test.js refactor: extract escapeRegex and validateTagSlugs server utils 2026-04-09 23:51:56 +01:00
events-recommended.test.js chore(board): remove old board tests, update seed + onboarding tests 2026-04-14 17:31:46 +01:00
helcim-auth.test.js Add Zod validation to all API endpoints and remove debug test route 2026-03-01 17:04:26 +00:00
helcim-customer.test.js feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
helcim-payment-history.test.js feat(billing): add payment history API route 2026-04-19 16:26:19 +01:00
helcim-payment.test.js feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
helcim-subscription.test.js feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
helcim-update-card.test.js feat(billing): add update-card API route with rollback + status gate 2026-04-19 16:29:23 +01:00
members-create-response.test.js Add Zod validation to all API endpoints and remove debug test route 2026-03-01 17:04:26 +00:00
members-create.test.js test(server): update member tests for contributionAmount rename 2026-04-19 18:55:46 +01:00
members-profile-patch.test.js test(server): update member tests for contributionAmount rename 2026-04-19 18:55:46 +01:00
onboarding-status.test.js feat(member): account/profile polish + tier upgrade flow 2026-04-14 20:35:37 +01:00
onboarding-track.test.js feat(member): account/profile polish + tier upgrade flow 2026-04-14 20:35:37 +01:00
reconcile-payments-route.test.js feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
series-tickets-purchase.test.js feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
update-contribution.test.js feat(payments): log Helcim charge on free-to-paid upgrade 2026-04-20 13:19:21 +01:00
upload-image.test.js feat: add testing infrastructure — Vitest, Playwright, CI, git hooks 2026-04-04 16:07:21 +01:00
validation-phase3.test.js feat(launch): security and correctness fixes for 2026-05-01 launch 2026-04-25 18:42:36 +01:00
validation.test.js feat(validation): rename contributionTier → contributionAmount in Zod schemas 2026-04-19 18:16:47 +01:00
wiki-recommended.test.js rename communityEcology → board across backend 2026-04-14 12:00:15 +01:00
wiki-sync.test.js test: align board-channels and wiki-sync mocks with current source 2026-04-17 09:50:50 +01:00