ghostguild-org/server/api/members/create.post.js
Jennie Robinson Faber 5023fb14ad fix(server): treat contributionAmount as cadence-unit (drop ×12)
ContributionAmountField now emits cadence-unit values (180 for $180/yr,
15 for $15/mo). Server endpoints were still multiplying annual by 12,
which would have charged $2160/yr instead of $180/yr after the form
ports in Tasks 2–3.

- helcim/subscription.post.js: recurringAmount = contributionAmount
  (no more × 12 for annual)
- members/update-contribution.post.js: same drop in both Case 1
  (free→paid) and Case 3 (paid→paid)
- slack.ts notifyNewMember: new positional `cadence` param so the
  Slack notification suffix renders /yr or /mo instead of hardcoded
  /month; all three call sites updated to pass member.billingCadence
- tests updated to match the new contract:
  - helcim-subscription.test.js: annual tests now send the cadence-
    unit amount (180, 600) and expect the same recurringAmount
  - update-contribution.test.js: annual Case 1 and Case 3 tests
    updated likewise
2026-05-23 15:37:52 +01:00

85 lines
No EOL
2.4 KiB
JavaScript

// server/api/members/create.post.js
import Member from '../../models/member.js'
import { connectDB } from '../../utils/mongoose.js'
import { getSlackService } from '../../utils/slack.ts'
import { validateBody } from '../../utils/validateBody.js'
import { memberCreateSchema } from '../../utils/schemas.js'
import { sendWelcomeEmail } from '../../utils/resend.js'
import { assignMemberNumber } from '../../utils/memberNumber.js'
export default defineEventHandler(async (event) => {
// Ensure database is connected
await connectDB()
const validatedData = await validateBody(event, memberCreateSchema)
try {
// Check if member already exists
const existingMember = await Member.findOne({ email: validatedData.email })
if (existingMember) {
throw createError({
statusCode: 409,
statusMessage: 'A member with this email already exists'
})
}
const member = new Member(validatedData)
await member.save()
await assignMemberNumber(member._id)
// Log member joined
logActivity(member._id, 'member_joined', {
circle: member.circle
}, { timestamp: member.createdAt })
// Auto-flag pre-existing Slack workspace members; admin manually invites the rest.
await autoFlagPreExistingSlackAccess(member)
try {
const slackService = getSlackService()
if (slackService) {
await slackService.notifyNewMember(
member.name,
member.email,
member.circle,
member.contributionAmount,
member.billingCadence,
'manual_invitation_required'
)
}
} catch (err) {
console.error('[slack] notifyNewMember failed:', err)
}
// Send welcome email (non-blocking)
try {
await sendWelcomeEmail(member)
logActivity(member._id, 'email_sent', {
emailType: 'welcome',
subject: 'Welcome to Ghost Guild'
})
} catch (emailError) {
console.error('Failed to send welcome email:', emailError)
}
return {
success: true,
member: {
id: member._id,
email: member.email,
name: member.name,
circle: member.circle,
contributionAmount: member.contributionAmount,
status: member.status
}
}
} catch (error) {
if (error.statusCode) {
throw error
}
throw createError({
statusCode: 400,
statusMessage: 'Member creation failed'
})
}
})