Jennie Robinson Faber
51230e5151
Follow-up to 208638e. Code review surfaced a few real issues; this
commit addresses them.
- login.post.js now uses the new sendMagicLink util instead of
duplicating the jti/jwt/Resend/logActivity logic. Reduces 60 lines.
- sendMagicLink accepts an optional pre-loaded Member doc, skipping
the redundant findOne when the caller already has one. customer.post.js
passes the just-created/upgraded member, dropping signup from 3
Mongo round-trips to 1 (lookup is gone; jti burn remains).
- sendMagicLink now lowercases the email defensively so callers don't
have to remember.
- rateLimit.js: replaced an effectively-dead eviction line with a
probabilistic sweep (~1% of calls scan and evict keys whose newest
entry has aged out). Caps unbounded Map growth under random-key
spraying.
- reconcile-payments.post.js: 401/403/404 from Helcim now bails out
immediately instead of burning all 3 retry attempts; dry-run
summary filters via the same RECONCILABLE_STATUSES set as apply
mode so counts match.
- Deleted WHAT-comments and section banners per CLAUDE.md no-comment
rule. Kept genuine WHY-comments (validateBeforeSave rationale,
amount-IGNORED-for-tickets, sendConfirmation deliberately-omitted).
Tests: 758/760 passing (unchanged).
110 lines
3.3 KiB
JavaScript
110 lines
3.3 KiB
JavaScript
/**
|
|
* Reconciliation cron route — invoked by `netlify/functions/reconcile-payments.mjs`.
|
|
*
|
|
* Auth: shared-secret header `X-Reconcile-Token` matched against
|
|
* `runtimeConfig.reconcileToken` (env: NUXT_RECONCILE_TOKEN). Machine-to-machine
|
|
* only — never passes `sendConfirmation: true` so back-fills don't re-send
|
|
* confirmation emails.
|
|
*/
|
|
import Member from '../../models/member.js'
|
|
import Payment from '../../models/payment.js'
|
|
import { listHelcimCustomerTransactions } from '../../utils/helcim.js'
|
|
import { upsertPaymentFromHelcim } from '../../utils/payments.js'
|
|
|
|
// Same filter upsertPaymentFromHelcim applies — keep dry-run summary in sync.
|
|
const RECONCILABLE_STATUSES = new Set(['paid', 'refunded', 'failed'])
|
|
|
|
const RETRY_ATTEMPTS = 3
|
|
const BASE_DELAY_MS = 250
|
|
|
|
function sleep(ms) {
|
|
return new Promise((resolve) => setTimeout(resolve, ms))
|
|
}
|
|
|
|
async function listTransactionsWithRetry(customerCode) {
|
|
let lastErr
|
|
for (let attempt = 1; attempt <= RETRY_ATTEMPTS; attempt++) {
|
|
try {
|
|
return await listHelcimCustomerTransactions(customerCode)
|
|
} catch (err) {
|
|
// Permanent failures (auth, missing) — don't burn retries on broken config.
|
|
if (err?.statusCode === 401 || err?.statusCode === 403 || err?.statusCode === 404) {
|
|
throw err
|
|
}
|
|
lastErr = err
|
|
// Backoff after attempts 1 and 2: 250ms, then 500ms (no sleep after attempt 3).
|
|
if (attempt < RETRY_ATTEMPTS) {
|
|
await sleep(BASE_DELAY_MS * 2 ** (attempt - 1))
|
|
}
|
|
}
|
|
}
|
|
throw lastErr
|
|
}
|
|
|
|
export default defineEventHandler(async (event) => {
|
|
const config = useRuntimeConfig()
|
|
const expected = config.reconcileToken
|
|
const provided = getHeader(event, 'x-reconcile-token')
|
|
if (!expected || provided !== expected) {
|
|
throw createError({ statusCode: 401, statusMessage: 'Unauthorized' })
|
|
}
|
|
|
|
const apply = getQuery(event).apply !== 'false'
|
|
|
|
const members = await Member.find(
|
|
{ helcimCustomerId: { $exists: true, $ne: null } },
|
|
{ _id: 1, email: 1, name: 1, helcimCustomerId: 1, helcimSubscriptionId: 1, billingCadence: 1 }
|
|
).lean()
|
|
|
|
let txExamined = 0
|
|
let created = 0
|
|
let existed = 0
|
|
let skipped = 0
|
|
let memberErrors = 0
|
|
|
|
for (const member of members) {
|
|
let txs
|
|
try {
|
|
txs = await listTransactionsWithRetry(member.helcimCustomerId)
|
|
} catch (err) {
|
|
memberErrors++
|
|
console.error(`[reconcile] member=${member._id}: ${err?.message || err}`)
|
|
continue
|
|
}
|
|
|
|
for (const tx of txs) {
|
|
txExamined++
|
|
if (!RECONCILABLE_STATUSES.has(tx?.status)) {
|
|
skipped++
|
|
continue
|
|
}
|
|
|
|
if (!apply) {
|
|
const existing = await Payment.findOne({ helcimTransactionId: tx.id })
|
|
if (existing) existed++
|
|
else created++
|
|
continue
|
|
}
|
|
|
|
// Note: deliberately NOT passing sendConfirmation — cron back-fills must
|
|
// not re-send confirmation emails for transactions the member has already
|
|
// been notified about (or that pre-date Mongo Payment tracking entirely).
|
|
const result = await upsertPaymentFromHelcim(member, tx)
|
|
if (result.created) created++
|
|
else if (result.payment) existed++
|
|
else skipped++
|
|
}
|
|
}
|
|
|
|
const summary = {
|
|
membersScanned: members.length,
|
|
txExamined,
|
|
created,
|
|
existed,
|
|
skipped,
|
|
memberErrors,
|
|
apply
|
|
}
|
|
console.log('[reconcile] done', summary)
|
|
return summary
|
|
})
|