Compare commits

..

5 commits

Author SHA1 Message Date
0d83003f87 test(visual): regenerate baselines to match current page state
Some checks failed
Test / vitest (pull_request) Successful in 11m51s
Test / playwright (pull_request) Failing after 9m37s
Test / visual (pull_request) Failing after 9m34s
Test / Notify on failure (pull_request) Successful in 3s
23 baselines updated to reflect intentional content evolution. Layouts
and design-system structure are unchanged — diffs are copy edits, refreshed
data, and (for /coming-soon) added pre-register / magic-link affordances.

Driven by: home hero copy + button labels changed; about/events/members
reflect updated content; admin pages reflect current member/event data;
SignupFlowOverlay structure on join; auth-gated routes redirect unauth
visitors to /join (members-mobile, members-desktop snapshots).

Spot-checked: coming-soon, members-mobile, home — all look right.
2026-04-26 18:34:37 +01:00
521efb0890 fix(a11y,test): USelect placeholder contrast + auth logout hydration wait
a11y (main.css):
- Nuxt UI's default placeholder color (text-dimmed = #a6a09b) failed WCAG
  AA contrast on cream (2.43:1) and white (2.58:1) backgrounds, blocking
  axe checks on /member/profile (timezone) and /admin/events/create
  (tags). Override [data-slot="placeholder"] globally to var(--text-dim)
  (#5a5040), comfortably above 4.5:1 on both surfaces.

auth.spec.js (logout):
- Same hydration race as the board/admin-board-channels click tests:
  /admin's sidebar Sign-out @click handler isn't bound when Playwright
  fires the click immediately after admin-tag visibility, so the click
  no-ops and waitForResponse for /api/auth/logout times out.
- Add waitForLoadState('networkidle') after goto so hydration completes
  before the click.
2026-04-26 18:30:32 +01:00
bb0dbfe53e test(e2e): align specs with current page structure
join-flow:
- Form now requires Community Guidelines agreement; tests check the
  checkbox before expecting submit to enable.
- Contribution input is a numeric field with preset chip buttons, not a
  USelect with $0/mo options — fill the input directly.
- Success state lives in SignupFlowOverlay ("Welcome to Ghost Guild!");
  no .success-box exists. Match by heading instead.
- Inline .error-box renders OUTSIDE <form>, so duplicate-email assertion
  uses .signup-flow-overlay .error-box (which is the user-facing error).

member-profile:
- "How you appear to other members" copy was retired; replace with the
  stable "Show in Member Directory" structural label.
- Add waitForLoadState('networkidle') after goto for ClientOnly auth
  hydration so "Edit Profile" reliably appears within timeout.

board:
- Add waitForLoadState('networkidle') after goto so the action-bar's
  "+ New Post" click handler is bound before the test clicks.
- Submit button is named exactly "Post" — disambiguate from "+ New Post"
  buttons with { exact: true }.
- Delete is a two-step in-card confirm (Delete → Confirm), not a native
  browser dialog; drop the page.once('dialog') listener.

admin-board-channels:
- Channel name placeholder is "e.g., coop-formation" (no leading #).
- Slack Channel ID input only appears in the Edit modal (v-if="editingId"),
  not on Create — Slack channel is auto-created server-side. Drop the
  slack ID fill from the Create step.
- Add waitForLoadState('networkidle') before opening the modal.
2026-04-26 18:28:14 +01:00
3f42307c64 fix(rate-limit): bypass middleware when ALLOW_DEV_TEST_ENDPOINTS=true
Parallel Playwright runs (6 workers, all from 127.0.0.1) burned through the
100 req/min generalLimiter budget within the first ~30s, causing every API
call (including /api/dev/test-login and /api/dev/member-login) to return 429
for the rest of the window. Auth helper waitForURL then timed out at 45s with
no redirect ever firing — surfacing as 8 cascading test failures across
auth.spec.js, board.spec.js, and admin-members.spec.js.

The bypass mirrors the existing gate used by /api/dev/* endpoints: the env
var is opt-in and only set in development (.env) or by Playwright's
webServer config. Production never sets it, so rate limiting remains active.
2026-04-26 18:06:32 +01:00
0c489cf2c3 style: underline contributor links + timezone select placeholder color
- join.vue: underline links inside .checkbox-label
- profile.vue: underline .posts-empty-link by default; remove hover-only
  underline rule; tint timezone select placeholder via :deep slot
2026-04-26 17:55:54 +01:00
32 changed files with 50 additions and 21 deletions

View file

@ -273,6 +273,14 @@ p a, blockquote a {
min-width: 0; min-width: 0;
} }
/* ---- Nuxt UI placeholder contrast ----
Default Nuxt UI placeholder uses `text-dimmed` (#a6a09b) which fails WCAG
AA on cream and white backgrounds (2.4:1). Override globally to --text-dim
so USelect/USelectMenu placeholders meet the 4.5:1 ratio. */
[data-slot="placeholder"] {
color: var(--text-dim);
}
/* ---- SHARED USelectMenu STYLES ---- /* ---- SHARED USelectMenu STYLES ----
Apply via: <USelectMenu class="zine-select" :ui="{ content: 'tz-content', item: 'tz-item', input: 'tz-input' }" /> Apply via: <USelectMenu class="zine-select" :ui="{ content: 'tz-content', item: 'tz-item', input: 'tz-input' }" />
Classes are global (not scoped) because Nuxt UI portals the popup content to body. */ Classes are global (not scoped) because Nuxt UI portals the popup content to body. */

View file

@ -1017,6 +1017,7 @@ onUnmounted(() => {
.checkbox-label a, .checkbox-label a,
.checkbox-label :deep(a) { .checkbox-label :deep(a) {
color: var(--candle); color: var(--candle);
text-decoration: underline;
} }
/* ---- ERROR & SUCCESS BOXES ---- */ /* ---- ERROR & SUCCESS BOXES ---- */

View file

@ -712,11 +712,11 @@ useHead({
.posts-empty-link { .posts-empty-link {
color: var(--candle); color: var(--candle);
text-decoration: none; text-decoration: underline;
} }
.posts-empty-link:hover { .timezone-select :deep([data-slot="placeholder"]) {
text-decoration: underline; color: var(--text-dim);
} }
.posts-list { .posts-list {

Binary file not shown.

Before

Width:  |  Height:  |  Size: 323 KiB

After

Width:  |  Height:  |  Size: 315 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 166 KiB

After

Width:  |  Height:  |  Size: 167 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 168 KiB

After

Width:  |  Height:  |  Size: 168 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 247 KiB

After

Width:  |  Height:  |  Size: 237 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 279 KiB

After

Width:  |  Height:  |  Size: 290 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 18 KiB

After

Width:  |  Height:  |  Size: 133 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 15 KiB

After

Width:  |  Height:  |  Size: 100 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 160 KiB

After

Width:  |  Height:  |  Size: 201 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 51 KiB

After

Width:  |  Height:  |  Size: 130 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 236 KiB

After

Width:  |  Height:  |  Size: 181 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 121 KiB

After

Width:  |  Height:  |  Size: 100 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 285 KiB

After

Width:  |  Height:  |  Size: 287 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 148 KiB

After

Width:  |  Height:  |  Size: 142 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 280 KiB

After

Width:  |  Height:  |  Size: 282 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 154 KiB

After

Width:  |  Height:  |  Size: 154 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 297 KiB

After

Width:  |  Height:  |  Size: 267 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 251 KiB

After

Width:  |  Height:  |  Size: 244 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 135 KiB

After

Width:  |  Height:  |  Size: 138 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 343 KiB

After

Width:  |  Height:  |  Size: 253 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 132 KiB

After

Width:  |  Height:  |  Size: 126 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 203 KiB

After

Width:  |  Height:  |  Size: 282 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 195 KiB

After

Width:  |  Height:  |  Size: 194 KiB

Before After
Before After

Binary file not shown.

Before

Width:  |  Height:  |  Size: 48 KiB

After

Width:  |  Height:  |  Size: 154 KiB

Before After
Before After

View file

@ -11,6 +11,7 @@ test.describe('Admin board channels page', () => {
test('create, edit, and delete a channel', async ({ adminPage }) => { test('create, edit, and delete a channel', async ({ adminPage }) => {
await adminPage.goto('/admin/board-channels') await adminPage.goto('/admin/board-channels')
await adminPage.waitForLoadState('networkidle')
await expect(adminPage.getByRole('heading', { name: 'Board Channels' })).toBeVisible({ await expect(adminPage.getByRole('heading', { name: 'Board Channels' })).toBeVisible({
timeout: 15000, timeout: 15000,
}) })
@ -18,14 +19,14 @@ test.describe('Admin board channels page', () => {
const suffix = Date.now().toString().slice(-6) const suffix = Date.now().toString().slice(-6)
const channelName = `e2e-channel-${suffix}` const channelName = `e2e-channel-${suffix}`
const editedName = `e2e-channel-${suffix}-edited` const editedName = `e2e-channel-${suffix}-edited`
const slackId = `C${suffix}XYZ`
// --- Create --- // --- Create ---
// Create flow only takes a name; the Slack channel ID is auto-assigned on
// creation and only becomes editable in the Edit modal.
await adminPage.getByRole('button', { name: '+ New Channel' }).click() await adminPage.getByRole('button', { name: '+ New Channel' }).click()
await expect(adminPage.getByRole('heading', { name: 'New Channel' })).toBeVisible() await expect(adminPage.getByRole('heading', { name: 'New Channel' })).toBeVisible()
await adminPage.locator('input[placeholder="e.g., #coop-formation"]').fill(channelName) await adminPage.locator('input[placeholder="e.g., coop-formation"]').fill(channelName)
await adminPage.locator('input[placeholder="C0123456789"]').fill(slackId)
// Select the first available cooperative tag if any are present // Select the first available cooperative tag if any are present
const firstTagCheckbox = adminPage.locator('.tag-select input[type="checkbox"]').first() const firstTagCheckbox = adminPage.locator('.tag-select input[type="checkbox"]').first()
@ -44,7 +45,7 @@ test.describe('Admin board channels page', () => {
await row.getByRole('button', { name: 'Edit' }).click() await row.getByRole('button', { name: 'Edit' }).click()
await expect(adminPage.getByRole('heading', { name: 'Edit Channel' })).toBeVisible() await expect(adminPage.getByRole('heading', { name: 'Edit Channel' })).toBeVisible()
const nameInput = adminPage.locator('input[placeholder="e.g., #coop-formation"]') const nameInput = adminPage.locator('input[placeholder="e.g., coop-formation"]')
await nameInput.fill(editedName) await nameInput.fill(editedName)
await adminPage.getByRole('button', { name: 'Save Changes' }).click() await adminPage.getByRole('button', { name: 'Save Changes' }).click()

View file

@ -44,6 +44,7 @@ test.describe('Authentication flows', () => {
test('logout clears auth', async ({ page }) => { test('logout clears auth', async ({ page }) => {
await loginAsAdmin(page) await loginAsAdmin(page)
await page.goto('/admin') await page.goto('/admin')
await page.waitForLoadState('networkidle')
await expect(page.locator('.admin-tag')).toBeVisible({ timeout: 15000 }) await expect(page.locator('.admin-tag')).toBeVisible({ timeout: 15000 })
// Set up response listener BEFORE clicking to avoid race // Set up response listener BEFORE clicking to avoid race

View file

@ -9,6 +9,7 @@ test.describe('Board page', () => {
test('clicking New Post reveals the form', async ({ memberPage }) => { test('clicking New Post reveals the form', async ({ memberPage }) => {
await memberPage.goto('/board') await memberPage.goto('/board')
await memberPage.waitForLoadState('networkidle')
await expect(memberPage.getByRole('button', { name: '+ New Post' }).first()).toBeVisible({ await expect(memberPage.getByRole('button', { name: '+ New Post' }).first()).toBeVisible({
timeout: 15000, timeout: 15000,
}) })
@ -40,6 +41,7 @@ test.describe('Board page', () => {
test('create, edit, and delete own post', async ({ memberPage }) => { test('create, edit, and delete own post', async ({ memberPage }) => {
await memberPage.goto('/board') await memberPage.goto('/board')
await memberPage.waitForLoadState('networkidle')
await expect(memberPage.getByRole('button', { name: '+ New Post' }).first()).toBeVisible({ await expect(memberPage.getByRole('button', { name: '+ New Post' }).first()).toBeVisible({
timeout: 15000, timeout: 15000,
}) })
@ -55,7 +57,7 @@ test.describe('Board page', () => {
await memberPage.locator('#post-title').fill(originalTitle) await memberPage.locator('#post-title').fill(originalTitle)
await memberPage.locator('#post-seeking').fill('Playwright test seeking text') await memberPage.locator('#post-seeking').fill('Playwright test seeking text')
await memberPage.getByRole('button', { name: 'Post' }).click() await memberPage.getByRole('button', { name: 'Post', exact: true }).click()
await expect(memberPage.getByRole('heading', { name: originalTitle })).toBeVisible({ await expect(memberPage.getByRole('heading', { name: originalTitle })).toBeVisible({
timeout: 10000, timeout: 10000,
@ -75,10 +77,10 @@ test.describe('Board page', () => {
timeout: 10000, timeout: 10000,
}) })
// --- Delete (confirm dialog) --- // --- Delete (in-card two-step confirm; not a native dialog) ---
memberPage.once('dialog', (dialog) => dialog.accept())
const editedCard = memberPage.locator('article.board-post', { hasText: editedTitle }) const editedCard = memberPage.locator('article.board-post', { hasText: editedTitle })
await editedCard.getByRole('button', { name: 'Delete' }).click() await editedCard.getByRole('button', { name: 'Delete' }).click()
await editedCard.getByRole('button', { name: 'Confirm' }).click()
await expect(memberPage.getByRole('heading', { name: editedTitle })).not.toBeVisible({ await expect(memberPage.getByRole('heading', { name: editedTitle })).not.toBeVisible({
timeout: 10000, timeout: 10000,

View file

@ -68,8 +68,12 @@ test.describe('Join page — member signup flow', () => {
await page.locator('#join-name').fill('Test User') await page.locator('#join-name').fill('Test User')
await expect(page.locator('.form-submit')).toBeDisabled() await expect(page.locator('.form-submit')).toBeDisabled()
// Fill email too — now all fields are populated and button should be enabled // Fill email — agreement still unchecked, so still disabled
await page.locator('#join-email').fill('incomplete-test@example.com') await page.locator('#join-email').fill('incomplete-test@example.com')
await expect(page.locator('.form-submit')).toBeDisabled()
// Check the Community Guidelines agreement — now all required fields satisfied
await page.getByRole('checkbox', { name: /Community Guidelines/ }).check()
await expect(page.locator('.form-submit')).toBeEnabled() await expect(page.locator('.form-submit')).toBeEnabled()
}) })
@ -83,8 +87,9 @@ test.describe('Join page — member signup flow', () => {
await page.locator('#join-name').fill('E2E Test User') await page.locator('#join-name').fill('E2E Test User')
await page.locator('#join-email').fill(uniqueEmail) await page.locator('#join-email').fill(uniqueEmail)
await page.locator('#circle-community').check({ force: true }) await page.locator('#circle-community').check({ force: true })
await page.locator('#join-contribution').click() // Contribution is now a numeric input with preset chips, not a select
await page.getByRole('option', { name: '$0/mo' }).click() await page.locator('#join-contribution').fill('0')
await page.getByRole('checkbox', { name: /Community Guidelines/ }).check()
await expect(page.locator('.form-submit')).toBeEnabled() await expect(page.locator('.form-submit')).toBeEnabled()
@ -93,8 +98,10 @@ test.describe('Join page — member signup flow', () => {
await page.locator('.form-submit').click() await page.locator('.form-submit').click()
// Free tier creates subscription then shows confirmation (step 3) // Free tier flips the SignupFlowOverlay into its success state
await expect(page.locator('.success-box')).toBeVisible({ timeout: 15000 }) await expect(
page.getByRole('heading', { name: 'Welcome to Ghost Guild!' })
).toBeVisible({ timeout: 15000 })
}) })
test('duplicate email shows error', async ({ page }) => { test('duplicate email shows error', async ({ page }) => {
@ -109,12 +116,13 @@ test.describe('Join page — member signup flow', () => {
await page.locator('#join-name').fill('Dup Test User') await page.locator('#join-name').fill('Dup Test User')
await page.locator('#join-email').fill(duplicateEmail) await page.locator('#join-email').fill(duplicateEmail)
await page.locator('#circle-community').check({ force: true }) await page.locator('#circle-community').check({ force: true })
await page.locator('#join-contribution').click() await page.locator('#join-contribution').fill('0')
await page.getByRole('option', { name: '$0/mo' }).click() await page.getByRole('checkbox', { name: /Community Guidelines/ }).check()
await page.locator('.form-submit').click() await page.locator('.form-submit').click()
// Should show an error about the email already existing // Helcim 409 puts SignupFlowOverlay into its error state
await expect(page.locator('.error-box')).toBeVisible({ timeout: 10000 }) const overlayError = page.locator('.signup-flow-overlay .error-box')
await expect(page.locator('.error-box')).toContainText(/already/i) await expect(overlayError).toBeVisible({ timeout: 10000 })
await expect(overlayError).toContainText(/already/i)
}) })
}) })

View file

@ -3,9 +3,11 @@ import { test, expect } from './helpers/fixtures.js'
test.describe('Member profile page', () => { test.describe('Member profile page', () => {
test('profile page loads', async ({ adminPage }) => { test('profile page loads', async ({ adminPage }) => {
await adminPage.goto('/member/profile') await adminPage.goto('/member/profile')
await adminPage.waitForLoadState('networkidle')
// Auth is checked client-side in onMounted — wait for profile form to render // Auth is checked client-side in onMounted — wait for profile form to render
await expect(adminPage.getByText('Edit Profile')).toBeVisible({ timeout: 15000 }) await expect(adminPage.getByText('Edit Profile')).toBeVisible({ timeout: 15000 })
await expect(adminPage.getByText('How you appear to other members')).toBeVisible() // Verify a stable structural section label, not transient marketing copy
await expect(adminPage.getByText('Show in Member Directory')).toBeVisible()
}) })
test('form fields are present', async ({ adminPage }) => { test('form fields are present', async ({ adminPage }) => {
@ -24,6 +26,7 @@ test.describe('Member profile page', () => {
test('bio field accepts input', async ({ adminPage }) => { test('bio field accepts input', async ({ adminPage }) => {
await adminPage.goto('/member/profile') await adminPage.goto('/member/profile')
await adminPage.waitForLoadState('networkidle')
await expect(adminPage.getByText('Edit Profile')).toBeVisible({ timeout: 15000 }) await expect(adminPage.getByText('Edit Profile')).toBeVisible({ timeout: 15000 })
const bio = adminPage.locator('textarea[placeholder*="Share your background"]') const bio = adminPage.locator('textarea[placeholder*="Share your background"]')

View file

@ -43,6 +43,11 @@ export default defineEventHandler(async (event) => {
const path = getRequestURL(event).pathname const path = getRequestURL(event).pathname
if (!path.startsWith('/api/')) return if (!path.startsWith('/api/')) return
// Bypass rate limiting in test/dev opt-in mode so parallel E2E runs from a
// single IP (127.0.0.1) do not exhaust the per-IP budget. Mirrors the gate
// used by /api/dev/* endpoints — only set in development and by Playwright.
if (process.env.ALLOW_DEV_TEST_ENDPOINTS === 'true') return
const ip = getClientIp(event) const ip = getClientIp(event)
try { try {