chore(board): remove old board tests, update seed + onboarding tests
This commit is contained in:
parent
7707068f36
commit
f3df1945bd
7 changed files with 55 additions and 638 deletions
|
|
@ -100,7 +100,6 @@ describe('useOnboarding', () => {
|
|||
})
|
||||
}
|
||||
if (url === '/api/events/recommended') return Promise.resolve([])
|
||||
if (url === '/api/board/suggestions') return Promise.resolve({ suggestions: [] })
|
||||
if (url === '/api/wiki/recommended') return Promise.resolve([])
|
||||
return Promise.resolve(null)
|
||||
})
|
||||
|
|
@ -252,7 +251,6 @@ describe('useOnboarding', () => {
|
|||
})
|
||||
}
|
||||
if (url === '/api/events/recommended') return Promise.resolve([])
|
||||
if (url === '/api/board/suggestions') return Promise.resolve({ suggestions: [] })
|
||||
if (url === '/api/wiki/recommended') return Promise.resolve([])
|
||||
return Promise.resolve(null)
|
||||
})
|
||||
|
|
@ -289,9 +287,6 @@ describe('useOnboarding', () => {
|
|||
if (url === '/api/events/recommended') {
|
||||
return Promise.resolve([{ _id: 'e1', title: 'Game Jam' }])
|
||||
}
|
||||
if (url === '/api/board/suggestions') {
|
||||
return Promise.resolve({ suggestions: [{ name: 'Alex' }] })
|
||||
}
|
||||
if (url === '/api/wiki/recommended') {
|
||||
return Promise.resolve([{ title: 'Co-op Guide', url: 'https://wiki.example.com/coop' }])
|
||||
}
|
||||
|
|
@ -329,9 +324,6 @@ describe('useOnboarding', () => {
|
|||
if (url === '/api/events/recommended') {
|
||||
return Promise.resolve([{ _id: 'e1', title: 'Game Jam' }])
|
||||
}
|
||||
if (url === '/api/board/suggestions') {
|
||||
return Promise.resolve({ suggestions: [] })
|
||||
}
|
||||
if (url === '/api/wiki/recommended') {
|
||||
return Promise.resolve([])
|
||||
}
|
||||
|
|
@ -373,7 +365,6 @@ describe('useOnboarding', () => {
|
|||
})
|
||||
}
|
||||
if (url === '/api/events/recommended') return Promise.resolve([])
|
||||
if (url === '/api/board/suggestions') return Promise.resolve({ suggestions: [] })
|
||||
if (url === '/api/wiki/recommended') return Promise.resolve([])
|
||||
return Promise.resolve(null)
|
||||
})
|
||||
|
|
|
|||
|
|
@ -1,325 +0,0 @@
|
|||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
|
||||
const { mockFind, mockSelect, mockLean } = vi.hoisted(() => ({
|
||||
mockFind: vi.fn(),
|
||||
mockSelect: vi.fn(),
|
||||
mockLean: vi.fn()
|
||||
}))
|
||||
|
||||
vi.mock('../../../server/models/member.js', () => ({
|
||||
default: { find: mockFind }
|
||||
}))
|
||||
|
||||
vi.mock('../../../server/utils/mongoose.js', () => ({
|
||||
connectDB: vi.fn()
|
||||
}))
|
||||
|
||||
vi.mock('../../../server/utils/auth.js', () => ({
|
||||
requireAuth: vi.fn()
|
||||
}))
|
||||
|
||||
import { requireAuth } from '../../../server/utils/auth.js'
|
||||
import handler from '../../../server/api/board/suggestions.get.js'
|
||||
import { createMockEvent } from '../helpers/createMockEvent.js'
|
||||
|
||||
function setupChain(result = []) {
|
||||
mockLean.mockResolvedValue(result)
|
||||
mockSelect.mockReturnValue({ lean: mockLean })
|
||||
mockFind.mockReturnValue({ select: mockSelect })
|
||||
}
|
||||
|
||||
function makeMember(overrides = {}) {
|
||||
return {
|
||||
_id: 'member-1',
|
||||
board: { topics: [] },
|
||||
...overrides
|
||||
}
|
||||
}
|
||||
|
||||
function makeCandidate(overrides = {}) {
|
||||
return {
|
||||
_id: 'candidate-1',
|
||||
name: 'Test Candidate',
|
||||
circle: 'community',
|
||||
avatar: '/avatar.jpg',
|
||||
craftTags: ['game-design'],
|
||||
board: {
|
||||
topics: [
|
||||
{ tagSlug: 'revenue-sharing', state: 'interested' }
|
||||
],
|
||||
offerPeerSupport: false,
|
||||
slackHandle: ''
|
||||
},
|
||||
privacy: {},
|
||||
...overrides
|
||||
}
|
||||
}
|
||||
|
||||
describe('GET /api/board/suggestions', () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
})
|
||||
|
||||
it('returns empty suggestions when member has no topics', async () => {
|
||||
const member = makeMember({ board: { topics: [] } })
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/board/suggestions' })
|
||||
const result = await handler(event)
|
||||
|
||||
expect(result).toEqual({ suggestions: [] })
|
||||
expect(mockFind).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('returns matching members with shared topics and correct state comparison', async () => {
|
||||
const member = makeMember({
|
||||
board: {
|
||||
topics: [
|
||||
{ tagSlug: 'revenue-sharing', state: 'help' },
|
||||
{ tagSlug: 'co-op-governance', state: 'seeking' }
|
||||
]
|
||||
}
|
||||
})
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
||||
const candidate = makeCandidate({
|
||||
board: {
|
||||
topics: [
|
||||
{ tagSlug: 'revenue-sharing', state: 'interested' }
|
||||
],
|
||||
offerPeerSupport: false
|
||||
}
|
||||
})
|
||||
setupChain([candidate])
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/board/suggestions' })
|
||||
const result = await handler(event)
|
||||
|
||||
expect(result.suggestions).toHaveLength(1)
|
||||
expect(result.suggestions[0].matchingTags).toEqual([
|
||||
{ tagSlug: 'revenue-sharing', yourState: 'help', theirState: 'interested' }
|
||||
])
|
||||
expect(result.suggestions[0].matchCount).toBe(1)
|
||||
})
|
||||
|
||||
it('excludes the requesting member from results', async () => {
|
||||
const member = makeMember({
|
||||
_id: 'member-1',
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'help' }]
|
||||
}
|
||||
})
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
||||
setupChain([])
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/board/suggestions' })
|
||||
await handler(event)
|
||||
|
||||
expect(mockFind).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
_id: { $ne: 'member-1' }
|
||||
})
|
||||
)
|
||||
})
|
||||
|
||||
it('respects avatar privacy settings', async () => {
|
||||
const member = makeMember({
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'help' }]
|
||||
}
|
||||
})
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
||||
const candidate = makeCandidate({
|
||||
privacy: { avatar: 'private' },
|
||||
avatar: '/secret-avatar.jpg',
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'interested' }],
|
||||
offerPeerSupport: false
|
||||
}
|
||||
})
|
||||
setupChain([candidate])
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/board/suggestions' })
|
||||
const result = await handler(event)
|
||||
|
||||
expect(result.suggestions[0].member.avatar).toBeUndefined()
|
||||
})
|
||||
|
||||
it('respects craftTags privacy settings', async () => {
|
||||
const member = makeMember({
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'help' }]
|
||||
}
|
||||
})
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
||||
const candidate = makeCandidate({
|
||||
privacy: { craftTags: 'private' },
|
||||
craftTags: ['game-design'],
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'interested' }],
|
||||
offerPeerSupport: false
|
||||
}
|
||||
})
|
||||
setupChain([candidate])
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/board/suggestions' })
|
||||
const result = await handler(event)
|
||||
|
||||
expect(result.suggestions[0].member.craftTags).toBeUndefined()
|
||||
})
|
||||
|
||||
it('exposes avatar when privacy is public', async () => {
|
||||
const member = makeMember({
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'help' }]
|
||||
}
|
||||
})
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
||||
const candidate = makeCandidate({
|
||||
privacy: { avatar: 'public' },
|
||||
avatar: '/public-avatar.jpg',
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'interested' }],
|
||||
offerPeerSupport: false
|
||||
}
|
||||
})
|
||||
setupChain([candidate])
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/board/suggestions' })
|
||||
const result = await handler(event)
|
||||
|
||||
expect(result.suggestions[0].member.avatar).toBe('/public-avatar.jpg')
|
||||
})
|
||||
|
||||
it('only exposes slackHandle when offerPeerSupport is true AND slackHandle is set', async () => {
|
||||
const member = makeMember({
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'help' }]
|
||||
}
|
||||
})
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
||||
// Case 1: offerPeerSupport false — no slackHandle
|
||||
const noSupport = makeCandidate({
|
||||
_id: 'c1',
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'interested' }],
|
||||
offerPeerSupport: false,
|
||||
slackHandle: 'someone'
|
||||
}
|
||||
})
|
||||
|
||||
// Case 2: offerPeerSupport true but no slackHandle
|
||||
const supportNoHandle = makeCandidate({
|
||||
_id: 'c2',
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'interested' }],
|
||||
offerPeerSupport: true,
|
||||
slackHandle: ''
|
||||
}
|
||||
})
|
||||
|
||||
// Case 3: offerPeerSupport true AND slackHandle set
|
||||
const supportWithHandle = makeCandidate({
|
||||
_id: 'c3',
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'interested' }],
|
||||
offerPeerSupport: true,
|
||||
slackHandle: 'helpfulperson'
|
||||
}
|
||||
})
|
||||
|
||||
setupChain([noSupport, supportNoHandle, supportWithHandle])
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/board/suggestions' })
|
||||
const result = await handler(event)
|
||||
|
||||
expect(result.suggestions[0].member.slackHandle).toBeUndefined()
|
||||
expect(result.suggestions[1].member.slackHandle).toBeUndefined()
|
||||
expect(result.suggestions[2].member.slackHandle).toBe('helpfulperson')
|
||||
})
|
||||
|
||||
it('filters by tag query param', async () => {
|
||||
const member = makeMember({
|
||||
board: {
|
||||
topics: [
|
||||
{ tagSlug: 'revenue-sharing', state: 'help' },
|
||||
{ tagSlug: 'co-op-governance', state: 'seeking' }
|
||||
]
|
||||
}
|
||||
})
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
||||
setupChain([])
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/board/suggestions?tag=revenue-sharing' })
|
||||
await handler(event)
|
||||
|
||||
// Should only query for the filtered tag
|
||||
expect(mockFind).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
'board.topics.tagSlug': { $in: ['revenue-sharing'] }
|
||||
})
|
||||
)
|
||||
})
|
||||
|
||||
it('sorts by matchCount descending', async () => {
|
||||
const member = makeMember({
|
||||
board: {
|
||||
topics: [
|
||||
{ tagSlug: 'revenue-sharing', state: 'help' },
|
||||
{ tagSlug: 'co-op-governance', state: 'seeking' },
|
||||
{ tagSlug: 'profit-sharing', state: 'interested' }
|
||||
]
|
||||
}
|
||||
})
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
||||
const oneMatch = makeCandidate({
|
||||
_id: 'c1',
|
||||
name: 'One Match',
|
||||
board: {
|
||||
topics: [{ tagSlug: 'revenue-sharing', state: 'interested' }],
|
||||
offerPeerSupport: false
|
||||
}
|
||||
})
|
||||
|
||||
const twoMatches = makeCandidate({
|
||||
_id: 'c2',
|
||||
name: 'Two Matches',
|
||||
board: {
|
||||
topics: [
|
||||
{ tagSlug: 'revenue-sharing', state: 'help' },
|
||||
{ tagSlug: 'co-op-governance', state: 'interested' }
|
||||
],
|
||||
offerPeerSupport: false
|
||||
}
|
||||
})
|
||||
|
||||
setupChain([oneMatch, twoMatches])
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/board/suggestions' })
|
||||
const result = await handler(event)
|
||||
|
||||
expect(result.suggestions[0].matchCount).toBe(2)
|
||||
expect(result.suggestions[0].member.name).toBe('Two Matches')
|
||||
expect(result.suggestions[1].matchCount).toBe(1)
|
||||
expect(result.suggestions[1].member.name).toBe('One Match')
|
||||
})
|
||||
|
||||
it('requires auth (401)', async () => {
|
||||
requireAuth.mockRejectedValue(
|
||||
createError({ statusCode: 401, statusMessage: 'Unauthorized' })
|
||||
)
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/board/suggestions' })
|
||||
|
||||
await expect(handler(event)).rejects.toMatchObject({
|
||||
statusCode: 401
|
||||
})
|
||||
})
|
||||
})
|
||||
|
|
@ -39,7 +39,6 @@ function makeMember(overrides = {}) {
|
|||
return {
|
||||
_id: 'member-1',
|
||||
craftTags: [],
|
||||
board: { topics: [] },
|
||||
...overrides
|
||||
}
|
||||
}
|
||||
|
|
@ -82,31 +81,6 @@ describe('GET /api/events/recommended', () => {
|
|||
)
|
||||
})
|
||||
|
||||
it('returns events matching cooperative tags from board.topics', async () => {
|
||||
const member = makeMember({
|
||||
board: {
|
||||
topics: [
|
||||
{ tagSlug: 'revenue-sharing', state: 'interested' },
|
||||
{ tagSlug: 'co-op-governance', state: 'help' }
|
||||
]
|
||||
}
|
||||
})
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
||||
const events = [makeEvent({ tags: ['revenue-sharing'] })]
|
||||
setupChain(events)
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/events/recommended' })
|
||||
const result = await handler(event)
|
||||
|
||||
expect(result).toEqual(events)
|
||||
expect(mockFind).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
tags: { $in: expect.arrayContaining(['revenue-sharing', 'co-op-governance']) }
|
||||
})
|
||||
)
|
||||
})
|
||||
|
||||
it('returns empty array when no tag overlap', async () => {
|
||||
const member = makeMember({ craftTags: ['audio'] })
|
||||
requireAuth.mockResolvedValue(member)
|
||||
|
|
|
|||
|
|
@ -1,5 +1,9 @@
|
|||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
|
||||
const { mockBoardPostExists } = vi.hoisted(() => ({
|
||||
mockBoardPostExists: vi.fn()
|
||||
}))
|
||||
|
||||
vi.mock('../../../server/utils/auth.js', () => ({
|
||||
requireAuth: vi.fn()
|
||||
}))
|
||||
|
|
@ -8,6 +12,10 @@ vi.mock('../../../server/utils/mongoose.js', () => ({
|
|||
connectDB: vi.fn()
|
||||
}))
|
||||
|
||||
vi.mock('../../../server/models/boardPost.js', () => ({
|
||||
default: { exists: mockBoardPostExists }
|
||||
}))
|
||||
|
||||
import { requireAuth } from '../../../server/utils/auth.js'
|
||||
import handler from '../../../server/api/onboarding/status.get.js'
|
||||
import { createMockEvent } from '../helpers/createMockEvent.js'
|
||||
|
|
@ -15,6 +23,7 @@ import { createMockEvent } from '../helpers/createMockEvent.js'
|
|||
describe('GET /api/onboarding/status', () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
mockBoardPostExists.mockResolvedValue(null)
|
||||
})
|
||||
|
||||
// 1.1: Default state for new member — all false, completedAt null
|
||||
|
|
@ -22,7 +31,6 @@ describe('GET /api/onboarding/status', () => {
|
|||
requireAuth.mockResolvedValue({
|
||||
_id: 'member-1',
|
||||
craftTags: [],
|
||||
board: { topics: [] },
|
||||
onboarding: {
|
||||
completedAt: null,
|
||||
eventPageVisited: false,
|
||||
|
|
@ -45,14 +53,11 @@ describe('GET /api/onboarding/status', () => {
|
|||
})
|
||||
})
|
||||
|
||||
// 1.2: hasProfileTags true when both tag types present
|
||||
it('hasProfileTags is true when member has both craft tags and board topics', async () => {
|
||||
// 1.2: hasProfileTags true when craft tags present
|
||||
it('hasProfileTags is true when member has craft tags', async () => {
|
||||
requireAuth.mockResolvedValue({
|
||||
_id: 'member-1',
|
||||
craftTags: ['game-design'],
|
||||
board: {
|
||||
topics: [{ tagSlug: 'governance', state: 'interested' }],
|
||||
},
|
||||
onboarding: {
|
||||
completedAt: null,
|
||||
eventPageVisited: false,
|
||||
|
|
@ -67,12 +72,11 @@ describe('GET /api/onboarding/status', () => {
|
|||
expect(result.goals.hasProfileTags).toBe(true)
|
||||
})
|
||||
|
||||
// 1.3: hasProfileTags false when only craft tags
|
||||
it('hasProfileTags is false when member has craft tags but no board topics', async () => {
|
||||
// 1.3: hasProfileTags false when no craft tags
|
||||
it('hasProfileTags is false when member has no craft tags', async () => {
|
||||
requireAuth.mockResolvedValue({
|
||||
_id: 'member-1',
|
||||
craftTags: ['game-design'],
|
||||
board: { topics: [] },
|
||||
craftTags: [],
|
||||
onboarding: {
|
||||
completedAt: null,
|
||||
eventPageVisited: false,
|
||||
|
|
@ -87,14 +91,11 @@ describe('GET /api/onboarding/status', () => {
|
|||
expect(result.goals.hasProfileTags).toBe(false)
|
||||
})
|
||||
|
||||
// 1.5: hasEngagedBoard true when visited AND has tag with engagement state
|
||||
it('hasEngagedBoard is true when page visited and has engaged topic', async () => {
|
||||
// 1.5: hasEngagedBoard true when visited AND has a BoardPost
|
||||
it('hasEngagedBoard is true when page visited and member has posted', async () => {
|
||||
requireAuth.mockResolvedValue({
|
||||
_id: 'member-1',
|
||||
craftTags: [],
|
||||
board: {
|
||||
topics: [{ tagSlug: 'governance', state: 'help' }],
|
||||
},
|
||||
onboarding: {
|
||||
completedAt: null,
|
||||
eventPageVisited: false,
|
||||
|
|
@ -102,19 +103,20 @@ describe('GET /api/onboarding/status', () => {
|
|||
wikiClicked: false,
|
||||
},
|
||||
})
|
||||
mockBoardPostExists.mockResolvedValue({ _id: 'post-1' })
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/onboarding/status' })
|
||||
const result = await handler(event)
|
||||
|
||||
expect(result.goals.hasEngagedBoard).toBe(true)
|
||||
expect(mockBoardPostExists).toHaveBeenCalledWith({ author: 'member-1' })
|
||||
})
|
||||
|
||||
// 1.6: hasEngagedBoard false when visited but no engagement state
|
||||
it('hasEngagedBoard is false when page visited but no topics have engagement state', async () => {
|
||||
// 1.6: hasEngagedBoard false when visited but no posts
|
||||
it('hasEngagedBoard is false when page visited but member has no posts', async () => {
|
||||
requireAuth.mockResolvedValue({
|
||||
_id: 'member-1',
|
||||
craftTags: [],
|
||||
board: { topics: [] },
|
||||
onboarding: {
|
||||
completedAt: null,
|
||||
eventPageVisited: false,
|
||||
|
|
@ -122,6 +124,7 @@ describe('GET /api/onboarding/status', () => {
|
|||
wikiClicked: false,
|
||||
},
|
||||
})
|
||||
mockBoardPostExists.mockResolvedValue(null)
|
||||
|
||||
const event = createMockEvent({ method: 'GET', path: '/api/onboarding/status' })
|
||||
const result = await handler(event)
|
||||
|
|
@ -134,7 +137,6 @@ describe('GET /api/onboarding/status', () => {
|
|||
requireAuth.mockResolvedValue({
|
||||
_id: 'member-1',
|
||||
craftTags: [],
|
||||
board: { topics: [] },
|
||||
onboarding: {
|
||||
completedAt: null,
|
||||
eventPageVisited: true,
|
||||
|
|
|
|||
|
|
@ -1,5 +1,13 @@
|
|||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
|
||||
const { mockBoardPostExists } = vi.hoisted(() => ({
|
||||
mockBoardPostExists: vi.fn()
|
||||
}))
|
||||
|
||||
vi.mock('../../../server/models/boardPost.js', () => ({
|
||||
default: { exists: mockBoardPostExists }
|
||||
}))
|
||||
|
||||
vi.mock('../../../server/utils/auth.js', () => ({
|
||||
requireAuth: vi.fn()
|
||||
}))
|
||||
|
|
@ -45,6 +53,7 @@ describe('POST /api/onboarding/track', () => {
|
|||
})
|
||||
Member.findByIdAndUpdate.mockResolvedValue({})
|
||||
Member.findOneAndUpdate.mockResolvedValue(null) // no graduation by default
|
||||
mockBoardPostExists.mockResolvedValue({ _id: 'post-1' })
|
||||
})
|
||||
|
||||
// 2.1: Sets eventPageVisited to true
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue