jennie/ghostguild-org
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(toast): rename Nuxt UI 4 toast.add timeout → duration
Some checks failed
Test / vitest (push) Successful in 11m3s
Details
Test / playwright (push) Failing after 9m29s
Details
Test / visual (push) Failing after 9m26s
Details
Test / Notify on failure (push) Successful in 3s
Details

Browse source 
Nuxt UI 4's Toast component reads `duration` (default 5000ms), not
`timeout` — the property was silently ignored. Behavior unchanged
since 5000ms matched the default. Fix the call site to be honest.

Strike the now-resolved gotcha from LAUNCH_READINESS.md.
This commit is contained in:
Jennie Robinson Faber 2026-04-27 19:50:38 +01:00
parent cf59931814
commit be24ae32fb
2 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/components/SeriesPassPurchase.vue
View file

@ -308,7 +308,7 @@ const handleSubmit = async () => {
title: "Series Pass Purchased!", title: "Series Pass Purchased!",
description: `You're now registered for all ${purchaseResponse.registration.eventsRegistered} events in this series.`, description: `You're now registered for all ${purchaseResponse.registration.eventsRegistered} events in this series.`,
color: "green", color: "green",
timeout: 5000, duration: 5000,
}); });
// Emit success event // Emit success event
@ -328,7 +328,7 @@ const handleSubmit = async () => {
title: "Purchase Failed", title: "Purchase Failed",
description: errorMessage, description: errorMessage,
color: "red", color: "red",
timeout: 5000, duration: 5000,
}); });
emit("purchase-error", errorMessage); emit("purchase-error", errorMessage);

1
docs/LAUNCH_READINESS.md
View file

@ -154,7 +154,6 @@ Context: Phase 4 audit against `docs/specs/events-visual-audit-findings.md` fixe
- **Success-state color convention (4 instances).** "You're Registered!" blocks use `--candle` (gold) instead of `--green`. Touches `EventSeriesTicketCard.vue:186-196` (still uses phantom `candlelight-*` classes — preserved byte-for-byte pending decision) and registered-state wrappers in `SeriesPassPurchase.vue`. Needs a UX call on whether success should render gold (zine-consistent) or green (semantic). Once decided, finish the phantom-palette removal on those 4 lines. - **Success-state color convention (4 instances).** "You're Registered!" blocks use `--candle` (gold) instead of `--green`. Touches `EventSeriesTicketCard.vue:186-196` (still uses phantom `candlelight-*` classes — preserved byte-for-byte pending decision) and registered-state wrappers in `SeriesPassPurchase.vue`. Needs a UX call on whether success should render gold (zine-consistent) or green (semantic). Once decided, finish the phantom-palette removal on those 4 lines.
- **Sidebar breakpoint unverified.** `app/layouts/default.vue:89` hides the sidebar at ≤1024px per spec. Browser `resize_window` tool refused viewport changes during the audit, so the actual crossover and any layout shift at 1023–1025px was never visually confirmed. Do a manual responsive check before declaring the sidebar pattern shipped. - **Sidebar breakpoint unverified.** `app/layouts/default.vue:89` hides the sidebar at ≤1024px per spec. Browser `resize_window` tool refused viewport changes during the audit, so the actual crossover and any layout shift at 1023–1025px was never visually confirmed. Do a manual responsive check before declaring the sidebar pattern shipped.
- **`EventTicketPurchase.vue:469` magic padding.** `.consent-hint { padding-left: 24px; }` is a hardcoded offset to align the hint under the checkbox text. Cosmetic; swap for a gap/grid approach when touching the consent block next. - **`EventTicketPurchase.vue:469` magic padding.** `.consent-hint { padding-left: 24px; }` is a hardcoded offset to align the hint under the checkbox text. Cosmetic; swap for a gap/grid approach when touching the consent block next.
- **Toast API rename unverified.** Nuxt UI v4 may have renamed `toast.add({ timeout })` → `{ duration }`. Current `SeriesPassPurchase.vue` toasts still pass `timeout`. No visible breakage, but worth confirming against current Nuxt UI docs.
- **`.section-label` extraction candidate.** Several audited files repeat the same uppercase/letter-spaced small label pattern inline. Low-priority refactor into a utility class in `main.css`. - **`.section-label` extraction candidate.** Several audited files repeat the same uppercase/letter-spaced small label pattern inline. Low-priority refactor into a utility class in `main.css`.
- **Past-events toggle component.** Existing, untouched this pass; noted in findings doc as a future consistency check. - **Past-events toggle component.** Existing, untouched this pass; noted in findings doc as a future consistency check.