Add Zod validation, fix mass assignment, remove test endpoints and dead code

- Add centralized Zod schemas (server/utils/schemas.js) and validateBody
  utility for all API endpoints
- Fix critical mass assignment in member creation: raw body no longer
  passed to new Member(), only validated fields (email, name, circle,
  contributionTier) are accepted
- Apply Zod validation to login, profile patch, event registration,
  updates, verify-payment, and admin event creation endpoints
- Fix logout cookie flags to match login (httpOnly: true, secure
  conditional on NODE_ENV)
- Delete unauthenticated test/debug endpoints (test-connection,
  test-subscription, test-bot)
- Remove sensitive console.log statements from Helcim and member
  endpoints
- Remove unused bcryptjs dependency
- Add 10MB file size limit on image uploads
- Use runtime config for JWT secret across all endpoints
- Add 38 validation tests (117 total, all passing)
This commit is contained in:
Jennie Robinson Faber 2026-03-01 14:02:46 +00:00
parent 26c300c357
commit b7279f57d1
41 changed files with 467 additions and 321 deletions

View file

@ -2,6 +2,8 @@
import Member from '../../models/member.js'
import { connectDB } from '../../utils/mongoose.js'
import { getSlackService } from '../../utils/slack.ts'
import { validateBody } from '../../utils/validateBody.js'
import { memberCreateSchema } from '../../utils/schemas.js'
// Simple payment check function to avoid import issues
const requiresPayment = (contributionValue) => contributionValue !== '0'
@ -14,7 +16,7 @@ async function inviteToSlack(member) {
return
}
console.log(`Processing Slack invitation for ${member.email}...`)
console.warn(`Processing Slack invitation for member`)
const inviteResult = await slackService.inviteUserToSlack(
member.email,
@ -45,13 +47,13 @@ async function inviteToSlack(member) {
inviteResult.status
)
console.log(`Successfully processed Slack invitation for ${member.email}: ${inviteResult.status}`)
console.warn(`Slack invitation processed: ${inviteResult.status}`)
} else {
// Update member record to reflect failed invitation
member.slackInviteStatus = 'failed'
await member.save()
console.error(`Failed to process Slack invitation for ${member.email}: ${inviteResult.error}`)
console.error(`Failed to process Slack invitation: ${inviteResult.error}`)
// Don't throw error - member creation should still succeed
}
} catch (error) {
@ -73,32 +75,30 @@ export default defineEventHandler(async (event) => {
// Ensure database is connected
await connectDB()
const body = await readBody(event)
const validatedData = await validateBody(event, memberCreateSchema)
try {
// Check if member already exists
const existingMember = await Member.findOne({ email: body.email })
const existingMember = await Member.findOne({ email: validatedData.email })
if (existingMember) {
throw createError({
statusCode: 409,
statusMessage: 'A member with this email already exists'
throw createError({
statusCode: 409,
statusMessage: 'A member with this email already exists'
})
}
const member = new Member(body)
const member = new Member(validatedData)
await member.save()
// Send Slack invitation for new members
await inviteToSlack(member)
// TODO: Process payment with Helcim if not free tier
if (requiresPayment(body.contributionTier)) {
if (requiresPayment(validatedData.contributionTier)) {
// Payment processing will be added here
console.log('Payment processing needed for tier:', body.contributionTier)
}
// TODO: Send welcome email
console.log('Welcome email should be sent to:', body.email)
return { success: true, member }
} catch (error) {