refactor(helcim): use centralized helper in 5 simple endpoints

server/api/helcim/get-or-create-customer.post.js

@@ -1,112 +1,43 @@
 // Get existing or create new Helcim customer (for upgrading members)
-import jwt from 'jsonwebtoken'
-import Member from '../../models/member.js'
-import { connectDB } from '../../utils/mongoose.js'
-
-const HELCIM_API_BASE = 'https://api.helcim.com/v2'
+import { requireAuth } from '../../utils/auth.js'
+import { findHelcimCustomerByEmail, createHelcimCustomer } from '../../utils/helcim.js'
 
 export default defineEventHandler(async (event) => {
   try {
-    await connectDB()
-    const config = useRuntimeConfig(event)
-    const token = getCookie(event, 'auth-token')
+    const member = await requireAuth(event)
 
-    if (!token) {
-      throw createError({
-        statusCode: 401,
-        statusMessage: 'Not authenticated'
-      })
-    }
-
-    // Decode JWT token
-    let decoded
+    // First, try to find an existing customer
+    let existingCustomer = null
     try {
-      decoded = jwt.verify(token, useRuntimeConfig().jwtSecret)
-    } catch (err) {
-      throw createError({
-        statusCode: 401,
-        statusMessage: 'Invalid or expired token'
-      })
-    }
-
-    // Get member
-    const member = await Member.findById(decoded.memberId)
-    if (!member) {
-      throw createError({
-        statusCode: 404,
-        statusMessage: 'Member not found'
-      })
-    }
-
-    const helcimToken = config.helcimApiToken
-
-    // First, search for existing customer
-    try {
-      const searchResponse = await fetch(
-        `${HELCIM_API_BASE}/customers?search=${encodeURIComponent(member.email)}`,
-        {
-          headers: {
-            'accept': 'application/json',
-            'api-token': helcimToken
-          }
-        }
-      )
-
-      if (searchResponse.ok) {
-        const searchData = await searchResponse.json()
-
-        if (searchData.customers && searchData.customers.length > 0) {
-          const existingCustomer = searchData.customers.find(c => c.email === member.email)
-
-          if (existingCustomer) {
-
-            // Update member record with customer ID if not already set
-            if (!member.helcimCustomerId) {
-              member.helcimCustomerId = existingCustomer.id
-              await member.save()
-            }
-
-            return {
-              success: true,
-              customerId: existingCustomer.id,
-              customerCode: existingCustomer.customerCode,
-              existing: true
-            }
-          }
-        }
+      const searchData = await findHelcimCustomerByEmail(member.email)
+      if (searchData.customers && searchData.customers.length > 0) {
+        existingCustomer = searchData.customers.find(c => c.email === member.email) || null
       }
     } catch (searchError) {
       console.error('Error searching for customer:', searchError)
-      // Continue to create new customer
+      // Fall through to create
     }
 
-    // No existing customer found, create new one
-    const createResponse = await fetch(`${HELCIM_API_BASE}/customers`, {
-      method: 'POST',
-      headers: {
-        'accept': 'application/json',
-        'content-type': 'application/json',
-        'api-token': helcimToken
-      },
-      body: JSON.stringify({
-        contactName: member.name,
-        businessName: member.name,
-        email: member.email
-      })
+    if (existingCustomer) {
+      if (!member.helcimCustomerId) {
+        member.helcimCustomerId = existingCustomer.id
+        await member.save()
+      }
+      return {
+        success: true,
+        customerId: existingCustomer.id,
+        customerCode: existingCustomer.customerCode,
+        existing: true
+      }
+    }
+
+    // No existing customer found — create one
+    const customerData = await createHelcimCustomer({
+      contactName: member.name,
+      businessName: member.name,
+      email: member.email
     })
 
-    if (!createResponse.ok) {
-      const errorText = await createResponse.text()
-      console.error('Failed to create Helcim customer:', createResponse.status, errorText)
-      throw createError({
-        statusCode: createResponse.status,
-        statusMessage: 'Customer creation failed'
-      })
-    }
-
-    const customerData = await createResponse.json()
-
-    // Update member record with customer ID
     member.helcimCustomerId = customerData.id
     await member.save()