From 73e67d02bb3c00518f7fc78c571ca18430bfc4ba Mon Sep 17 00:00:00 2001 From: Jennie Robinson Faber Date: Fri, 1 May 2026 13:35:50 +0100 Subject: [PATCH] build(playwright): drop OS suffix from snapshot path MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Visual baselines were generated as chromium-darwin.png on macOS; CI on Linux looked for chromium-linux.png and every test failed with "snapshot doesn't exist". Override snapshotPathTemplate to omit the platform suffix so darwin and linux share the same baseline. Pixel diffs from font hinting are an accepted trade-off — visual regression gives signal for big visual breaks, not 1-pixel differences. Existing 26 baselines renamed from *-chromium-darwin.png to *-chromium.png to match. --- ...romium-darwin.png => about-desktop-chromium.png} | Bin ...um-darwin.png => about-mobile-auth-chromium.png} | Bin ...hromium-darwin.png => about-mobile-chromium.png} | Bin ...win.png => admin-dashboard-desktop-chromium.png} | Bin ...png => admin-events-create-desktop-chromium.png} | Bin ...arwin.png => admin-members-desktop-chromium.png} | Bin ...-darwin.png => coming-soon-desktop-chromium.png} | Bin ...m-darwin.png => coming-soon-mobile-chromium.png} | Bin ...-darwin.png => connections-desktop-chromium.png} | Bin ...win.png => connections-mobile-auth-chromium.png} | Bin ...omium-darwin.png => events-desktop-chromium.png} | Bin ...romium-darwin.png => events-mobile-chromium.png} | Bin ...hromium-darwin.png => home-desktop-chromium.png} | Bin ...chromium-darwin.png => home-mobile-chromium.png} | Bin ...hromium-darwin.png => join-desktop-chromium.png} | Bin ...chromium-darwin.png => join-mobile-chromium.png} | Bin ...rwin.png => member-account-desktop-chromium.png} | Bin ....png => member-account-mobile-auth-chromium.png} | Bin ...win.png => member-activity-desktop-chromium.png} | Bin ...in.png => member-dashboard-desktop-chromium.png} | Bin ...ng => member-dashboard-mobile-auth-chromium.png} | Bin ...rwin.png => member-profile-desktop-chromium.png} | Bin ....png => member-profile-mobile-auth-chromium.png} | Bin ...mium-darwin.png => members-desktop-chromium.png} | Bin ...rwin.png => members-detail-desktop-chromium.png} | Bin ...omium-darwin.png => members-mobile-chromium.png} | Bin playwright.config.js | 1 + 27 files changed, 1 insertion(+) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{about-desktop-chromium-darwin.png => about-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{about-mobile-auth-chromium-darwin.png => about-mobile-auth-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{about-mobile-chromium-darwin.png => about-mobile-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{admin-dashboard-desktop-chromium-darwin.png => admin-dashboard-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{admin-events-create-desktop-chromium-darwin.png => admin-events-create-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{admin-members-desktop-chromium-darwin.png => admin-members-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{coming-soon-desktop-chromium-darwin.png => coming-soon-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{coming-soon-mobile-chromium-darwin.png => coming-soon-mobile-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{connections-desktop-chromium-darwin.png => connections-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{connections-mobile-auth-chromium-darwin.png => connections-mobile-auth-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{events-desktop-chromium-darwin.png => events-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{events-mobile-chromium-darwin.png => events-mobile-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{home-desktop-chromium-darwin.png => home-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{home-mobile-chromium-darwin.png => home-mobile-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{join-desktop-chromium-darwin.png => join-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{join-mobile-chromium-darwin.png => join-mobile-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{member-account-desktop-chromium-darwin.png => member-account-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{member-account-mobile-auth-chromium-darwin.png => member-account-mobile-auth-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{member-activity-desktop-chromium-darwin.png => member-activity-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{member-dashboard-desktop-chromium-darwin.png => member-dashboard-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{member-dashboard-mobile-auth-chromium-darwin.png => member-dashboard-mobile-auth-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{member-profile-desktop-chromium-darwin.png => member-profile-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{member-profile-mobile-auth-chromium-darwin.png => member-profile-mobile-auth-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{members-desktop-chromium-darwin.png => members-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{members-detail-desktop-chromium-darwin.png => members-detail-desktop-chromium.png} (100%) rename e2e/__screenshots__/visual/pages.spec.js-snapshots/{members-mobile-chromium-darwin.png => members-mobile-chromium.png} (100%) diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/about-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/about-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/about-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/about-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/about-mobile-auth-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/about-mobile-auth-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/about-mobile-auth-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/about-mobile-auth-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/about-mobile-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/about-mobile-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/about-mobile-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/about-mobile-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-dashboard-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-dashboard-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-dashboard-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-dashboard-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-events-create-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-events-create-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-events-create-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-events-create-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-members-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-members-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-members-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/admin-members-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/coming-soon-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/coming-soon-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/coming-soon-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/coming-soon-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/coming-soon-mobile-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/coming-soon-mobile-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/coming-soon-mobile-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/coming-soon-mobile-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/connections-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/connections-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/connections-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/connections-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/connections-mobile-auth-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/connections-mobile-auth-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/connections-mobile-auth-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/connections-mobile-auth-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/events-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/events-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/events-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/events-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/events-mobile-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/events-mobile-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/events-mobile-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/events-mobile-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/home-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/home-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/home-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/home-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/home-mobile-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/home-mobile-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/home-mobile-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/home-mobile-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/join-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/join-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/join-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/join-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/join-mobile-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/join-mobile-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/join-mobile-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/join-mobile-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-account-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-account-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/member-account-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/member-account-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-account-mobile-auth-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-account-mobile-auth-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/member-account-mobile-auth-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/member-account-mobile-auth-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-activity-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-activity-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/member-activity-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/member-activity-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-dashboard-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-dashboard-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/member-dashboard-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/member-dashboard-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-dashboard-mobile-auth-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-dashboard-mobile-auth-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/member-dashboard-mobile-auth-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/member-dashboard-mobile-auth-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-profile-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-profile-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/member-profile-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/member-profile-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-profile-mobile-auth-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/member-profile-mobile-auth-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/member-profile-mobile-auth-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/member-profile-mobile-auth-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/members-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/members-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/members-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/members-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/members-detail-desktop-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/members-detail-desktop-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/members-detail-desktop-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/members-detail-desktop-chromium.png diff --git a/e2e/__screenshots__/visual/pages.spec.js-snapshots/members-mobile-chromium-darwin.png b/e2e/__screenshots__/visual/pages.spec.js-snapshots/members-mobile-chromium.png similarity index 100% rename from e2e/__screenshots__/visual/pages.spec.js-snapshots/members-mobile-chromium-darwin.png rename to e2e/__screenshots__/visual/pages.spec.js-snapshots/members-mobile-chromium.png diff --git a/playwright.config.js b/playwright.config.js index 49d322d..0fc414b 100644 --- a/playwright.config.js +++ b/playwright.config.js @@ -7,6 +7,7 @@ export default defineConfig({ testDir: "./e2e", outputDir: "e2e/test-results", snapshotDir: "e2e/__screenshots__", + snapshotPathTemplate: "{snapshotDir}/{testFileDir}/{testFileName}-snapshots/{arg}-{projectName}{ext}", fullyParallel: false, forbidOnly: !!process.env.CI, retries: process.env.CI ? 1 : 1,