From 55c57d263dea60029e201b2fa904cbe152d776b7 Mon Sep 17 00:00:00 2001 From: Jennie Robinson Faber Date: Wed, 29 Apr 2026 20:25:57 +0100 Subject: [PATCH] docs(backlog): strike shipped items in launch-readiness post-launch list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Strikes: - memberSavings inactive-member block (shipped f66455e) - Success-state color convention 4-instances (gold chosen, shipped dc2becf) - Sidebar 1024px breakpoint verified clean - EventTicketPurchase magic 24px padding (shipped 7e44809) - .section-label extraction (already extracted at main.css:128) - Contribution-amount cosmetic cleanup (shipped 955217a) - Reconcile customerCode bug (shipped 3c38333, pre-existing on main) Adds: - Pointer noting EventSeriesBadge.vue is unused — delete in a future pass. - Pointer noting Simplify-pass follow-ups are documented in memory. --- docs/LAUNCH_READINESS.md | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/docs/LAUNCH_READINESS.md b/docs/LAUNCH_READINESS.md index cd0329d..bcd8440 100644 --- a/docs/LAUNCH_READINESS.md +++ b/docs/LAUNCH_READINESS.md @@ -137,8 +137,10 @@ See `docs/TODO.md` for: - ~~Admin dashboard quick-action button contrast~~ — verified stale 2026-04-29. - ~~Members table NAME column clipping~~ — verified stale 2026-04-29. - OWASP ASVS L1 Phase 4 (file-upload validation pipeline, granular RBAC, credential encryption). -- `tickets/available.get.js:115` `memberSavings` block reports `$0 saved` for inactive members — cosmetic; suppress comparison block when `!hasMemberAccess(member)` if it ever surfaces in UI. -- Simplify-pass follow-ups (2026-04-25): source-grep test bloat, login/verify rate-limit gap, stringly-typed `metadata.type`, reconcile-payments sequential loop, stale `new Date()` in events list, `loadPublicSeries` helper extraction. +- ~~`tickets/available.get.js:115` `memberSavings` block reports `$0 saved` for inactive members~~ — fixed 2026-04-29 (commit `f66455e`); `memberSavings` now gated on `hasMemberAccess(member)`. +- Simplify-pass follow-ups (2026-04-25): SHIPPED 2026-04-27 on branch `chore/simplify-pass-follow-ups` (pending merge). See `~/.claude/projects/-Users-jennie-Sites-ghostguild-org/memory/project_simplify_pass_2026_04_25.md`. +- ~~Reconcile `customerCode` bug~~ — fixed on `main` in commit `3c38333` ("pass customerCode (not helcimCustomerId) to Helcim transactions API"). Verified in `server/api/internal/reconcile-payments.post.js:97`. +- Drive-by from 2026-04-29 phantom-Tailwind sweep: `app/components/EventSeriesBadge.vue` has zero usages in `app/` or `server/`. Candidate for deletion in a future cleanup pass. ### Known gotchas worth addressing post-launch @@ -150,14 +152,13 @@ See `docs/TODO.md` for: Context: Phase 4 audit against `docs/specs/events-visual-audit-findings.md` fixed all critical phantom-palette, rounded-corner, CTA-mismatch, and input-styling issues across `EventTicketCard`, `EventTicketPurchase`, `EventSeriesTicketCard`, `SeriesPassPurchase`. Items below were explicitly deferred or out of reach. -- **Success-state color convention (4 instances).** "You're Registered!" blocks use `--candle` (gold) instead of `--green`. Touches `EventSeriesTicketCard.vue:186-196` (still uses phantom `candlelight-*` classes — preserved byte-for-byte pending decision) and registered-state wrappers in `SeriesPassPurchase.vue`. Needs a UX call on whether success should render gold (zine-consistent) or green (semantic). Once decided, finish the phantom-palette removal on those 4 lines. -- **Sidebar breakpoint unverified.** `app/layouts/default.vue:89` hides the sidebar at ≤1024px per spec. Browser `resize_window` tool refused viewport changes during the audit, so the actual crossover and any layout shift at 1023–1025px was never visually confirmed. Do a manual responsive check before declaring the sidebar pattern shipped. -- **`EventTicketPurchase.vue:469` magic padding.** `.consent-hint { padding-left: 24px; }` is a hardcoded offset to align the hint under the checkbox text. Cosmetic; swap for a gap/grid approach when touching the consent block next. -- **`.section-label` extraction candidate.** Several audited files repeat the same uppercase/letter-spaced small label pattern inline. Low-priority refactor into a utility class in `main.css`. +- ~~**Success-state color convention (4 instances).**~~ Resolved 2026-04-29: gold (`--candle`) chosen as zine-consistent. Phantom-Tailwind cleanup shipped in `dc2becf` (`EventSeriesTicketCard.vue` + `SeriesPassPurchase.vue` member-benefit notice). +- ~~**Sidebar breakpoint unverified.**~~ Verified clean 2026-04-29 — `.events-mini` hides at ≤1024px cleanly across 1023/1024/1025/1100. Actual rule lives in `EventsMiniSidebar.vue:129` + `ColumnsLayout.vue:83` (audit doc cited the wrong line). +- ~~**`EventTicketPurchase.vue:469` magic padding.**~~ Fixed 2026-04-29 (commit `7e44809`); consent block now uses a grid approach. +- ~~**`.section-label` extraction candidate.**~~ Verified 2026-04-29 — utility already exists at `main.css:128` and is used in 30+ places. Two scoped overrides intentionally diverge. - **Past-events toggle component.** Existing, untouched this pass; noted in findings doc as a future consistency check. ### Contribution-amount redesign — cosmetic cleanup (naming only, not behavior) -- Rename admin members column header "Tier" → "Contribution" (`app/pages/admin/members/index.vue:265`). -- Update error log message referencing "tier" in `server/api/members/update-contribution.post.js:221`. -- Rename `handleUpdateTier` handler in `app/pages/member/account.vue`. + +SHIPPED 2026-04-29 in commit `955217a` (admin column header, dropdown labels, handler rename, log message).