jennie/ghostguild-org
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: phase 4 cleanup — delete SidebarLayout, drop dashboard-body

Browse source 
Now that all member-area pages have migrated to PageShell +
ColumnsLayout, SidebarLayout has no consumers and can be deleted.
PageShell owns the flex chain, so the .dashboard-body wrapper on
member/dashboard.vue (flex: 1; display: flex; flex-direction: column;
min-height: 0) is redundant. Update stale SidebarLayout comments on
members/[id].vue to reference ColumnsLayout.
This commit is contained in:
Jennie Robinson Faber 2026-04-08 17:58:01 +01:00
parent 4a5b129eeb
commit 3b5b0d831d
3 changed files with 5 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

43
app/components/SidebarLayout.vue
View file

@ -1,43 +0,0 @@
<template>
<div class="sidebar-layout">
<div class="sidebar-layout-main">
<slot />
</div>
<EventsMiniSidebar :events="upcomingEvents" />
</div>
</template>
<script setup>
const props = defineProps({
limit: { type: Number, default: 3 },
})
const { data: upcomingEvents } = await useFetch('/api/events', {
query: { limit: props.limit, upcoming: true },
default: () => [],
})
</script>
<style scoped>
.sidebar-layout {
flex: 1;
display: grid;
grid-template-columns: 1fr 200px;
align-items: stretch;
min-height: 0;
}
.sidebar-layout-main {
min-width: 0;
align-self: stretch;
display: flex;
flex-direction: column;
min-height: 0;
}
@media (max-width: 1024px) {
.sidebar-layout {
grid-template-columns: 1fr;
}
}
</style>

13
app/pages/member/dashboard.vue
View file

@ -27,9 +27,8 @@
<!-- Dashboard Content -->
<template v-else>
<ColumnsLayout cols="events-sidebar" :limit="5">
<div class="dashboard-body">
<!-- Member Status Banner -->
<MemberStatusBanner />
<!-- Member Status Banner -->
<MemberStatusBanner />
<!-- Welcome Header -->
<PageHeader :title="`Welcome back, ${memberData?.name || ''}`">
@ -202,7 +201,6 @@
</DashedBox>
</div>
</div>
</div>
</ColumnsLayout>
</template>
@ -451,13 +449,6 @@ useHead({
margin-top: 8px;
}
.dashboard-body {
flex: 1;
display: flex;
flex-direction: column;
min-height: 0;
}
.content-row {
display: grid;
grid-template-columns: repeat(2, minmax(0, 1fr));

6
app/pages/members/[id].vue
View file

@ -15,7 +15,7 @@
<!-- Profile Content -->
<template v-else>
<!-- HERO: full-bleed, outside SidebarLayout -->
<!-- HERO: full-bleed, outside ColumnsLayout -->
<div class="profile-hero" :class="{ 'profile-hero--with-links': hasSocialLinks }">
<!-- Left: Avatar + Identity -->
@ -514,7 +514,7 @@ useHead({
}
/* ====================================================
SECTIONS — inside SidebarLayout
SECTIONS — inside ColumnsLayout
==================================================== */
.profile-section {
@ -734,7 +734,7 @@ useHead({
==================================================== */
@media (max-width: 1024px) {
/* SidebarLayout sidebar hides itself at ≤1024px */
/* ColumnsLayout events-sidebar hides itself at ≤1024px */
.profile-two-col {
grid-template-columns: 1fr;
}