refactor(events): gate member benefits on hasMemberAccess

Extracts hasMemberAccess(member) in tickets.js and uses it across event
registration, ticket purchase, and series purchase flows so guest, suspended,
and cancelled records no longer count as members while pending_payment still
does.

server/api/events/[id]/register.post.js

@@ -4,6 +4,7 @@ import { connectDB } from "../../../utils/mongoose.js";
 import { sendEventRegistrationEmail } from "../../../utils/resend.js";
 import { validateBody } from "../../../utils/validateBody.js";
 import { eventRegistrationSchema } from "../../../utils/schemas.js";
+import { hasMemberAccess } from "../../../utils/tickets.js";
 import mongoose from "mongoose";
 
 export default defineEventHandler(async (event) => {
@@ -63,10 +64,13 @@ export default defineEventHandler(async (event) => {
       });
     }
 
-    // Check member status and handle different registration scenarios
+    // Check member status and handle different registration scenarios.
+    // Member access is decoupled from payment status: active and pending_payment
+    // both confer access; guest, suspended, and cancelled do not.
     const member = await Member.findOne({ email: body.email.toLowerCase() });
+    const memberHasAccess = hasMemberAccess(member);
 
-    if (eventData.membersOnly && !member) {
+    if (eventData.membersOnly && !memberHasAccess) {
       throw createError({
         statusCode: 403,
         statusMessage:
@@ -78,7 +82,7 @@ export default defineEventHandler(async (event) => {
     if (
       eventData.pricing?.paymentRequired &&
       !eventData.pricing?.isFree &&
-      !member
+      !memberHasAccess
     ) {
       throw createError({
         statusCode: 402, // Payment Required
@@ -91,7 +95,7 @@ export default defineEventHandler(async (event) => {
     let isMember = false;
     let membershipLevel = "non-member";
 
-    if (member) {
+    if (memberHasAccess) {
       isMember = true;
       membershipLevel = `${member.circle}-${member.contributionTier}`;
     }

server/api/events/[id]/tickets/purchase.post.js

@@ -5,6 +5,7 @@ import {
   validateTicketPurchase,
   calculateTicketPrice,
   completeTicketPurchase,
+  hasMemberAccess,
 } from "../../../../utils/tickets.js";
 import { sendEventRegistrationEmail } from "../../../../utils/resend.js";
 import mongoose from "mongoose";
@@ -43,16 +44,17 @@ export default defineEventHandler(async (event) => {
       });
     }
 
-    // Check if user is a member. Guests don't count as members for pricing/validation.
+    // Check if user is a member. Only members with access (active or
+    // pending_payment) count for pricing/validation; guest, suspended,
+    // and cancelled members are treated as non-members.
     let member = await Member.findOne({ email: body.email.toLowerCase() });
     let accountCreated = false;
-    const isRealMember = (m) => !!m && m.status !== "guest";
 
     // Validate ticket purchase
     const validation = validateTicketPurchase(eventData, {
       email: body.email,
       name: body.name,
-      member: isRealMember(member) ? member : null,
+      member: hasMemberAccess(member) ? member : null,
     });
 
     if (!validation.valid) {
@@ -109,15 +111,15 @@ export default defineEventHandler(async (event) => {
     }
 
     // Create registration
-    const realMember = isRealMember(member);
+    const memberHasAccess = hasMemberAccess(member);
     const registration = {
       memberId: member ? member._id : null,
       name: body.name,
       email: body.email.toLowerCase(),
-      membershipLevel: realMember
+      membershipLevel: memberHasAccess
         ? `${member.circle}-${member.contributionTier}`
         : "non-member",
-      isMember: realMember,
+      isMember: memberHasAccess,
       ticketType: ticketInfo.ticketType,
       ticketPrice: ticketInfo.price,
       paymentStatus: requiresPayment ? "completed" : "not_required",

server/api/series/[id]/tickets/purchase.post.js

@@ -8,6 +8,7 @@ import {
   releaseSeriesTicket,
   completeSeriesTicketPurchase,
   registerForAllSeriesEvents,
+  hasMemberAccess,
 } from "../../../../utils/tickets.js";
 import { sendSeriesPassConfirmation } from "../../../../utils/resend.js";
 
@@ -33,7 +34,9 @@ export default defineEventHandler(async (event) => {
       });
     }
 
-    // Check membership — prefer JWT auth for accurate member pricing
+    // Check membership — prefer JWT auth for accurate member pricing.
+    // Only members with access (active or pending_payment) get member-tier
+    // pricing; guest, suspended, and cancelled are treated as non-members.
     let member = null;
     try {
       member = await requireAuth(event);
@@ -46,12 +49,13 @@ export default defineEventHandler(async (event) => {
 
     // Resolve canonical email: use authenticated member's email if available
     const canonicalEmail = member ? member.email : email.toLowerCase();
+    const accessMember = hasMemberAccess(member) ? member : null;
 
     // Validate purchase
     const validation = validateSeriesTicketPurchase(series, {
       email: canonicalEmail,
       name,
-      member,
+      member: accessMember,
     });
 
     if (!validation.valid) {
@@ -84,8 +88,8 @@ export default defineEventHandler(async (event) => {
       memberId: member?._id,
       name,
       email: canonicalEmail,
-      membershipLevel: member?.circle || "non-member",
-      isMember: !!member,
+      membershipLevel: accessMember?.circle || "non-member",
+      isMember: !!accessMember,
       ticketType: ticketInfo.ticketType,
       ticketPrice: ticketInfo.price,
       paymentStatus: ticketInfo.isFree ? "not_required" : "completed",

server/utils/tickets.js

@@ -1,5 +1,14 @@
 // Ticket business logic utilities
 
+/**
+ * Whether a Member document confers member-tier access to events.
+ * Status `active` and `pending_payment` are equivalent for access (payment is
+ * decoupled from membership). Status `guest`, `suspended`, `cancelled`, or no
+ * member at all do not confer access.
+ */
+export const hasMemberAccess = (member) =>
+  !!member && (member.status === "active" || member.status === "pending_payment");
+
 /**
  * Calculate the applicable ticket price for a user
  * @param {Object} event - Event document
@@ -7,15 +16,18 @@
  * @returns {Object} { ticketType, price, currency, isEarlyBird }
  */
 export const calculateTicketPrice = (event, member = null) => {
+  // Members without access (guest/suspended/cancelled) get public pricing only.
+  const accessMember = hasMemberAccess(member) ? member : null;
+
   if (!event.tickets?.enabled) {
     // Legacy pricing model
     if (event.pricing?.paymentRequired && !event.pricing?.isFree) {
       return {
-        ticketType: member ? "member" : "public",
-        price: member ? 0 : event.pricing.publicPrice,
+        ticketType: accessMember ? "member" : "public",
+        price: accessMember ? 0 : event.pricing.publicPrice,
         currency: event.pricing.currency || "CAD",
         isEarlyBird: false,
-        isFree: member ? true : event.pricing.publicPrice === 0,
+        isFree: accessMember ? true : event.pricing.publicPrice === 0,
       };
     }
     return {
@@ -30,14 +42,14 @@ export const calculateTicketPrice = (event, member = null) => {
   const now = new Date();
 
   // Member pricing
-  if (member && event.tickets.member?.available) {
+  if (accessMember && event.tickets.member?.available) {
     const memberTicket = event.tickets.member;
     let price = memberTicket.price || 0;
     let isFree = memberTicket.isFree;
 
     // Check for circle-specific overrides
-    if (memberTicket.circleOverrides && member.circle) {
-      const circleOverride = memberTicket.circleOverrides[member.circle];
+    if (memberTicket.circleOverrides && accessMember.circle) {
+      const circleOverride = memberTicket.circleOverrides[accessMember.circle];
       if (circleOverride) {
         if (circleOverride.isFree !== undefined) {
           isFree = circleOverride.isFree;
@@ -200,7 +212,7 @@ export const validateTicketPurchase = (event, user) => {
   }
 
   // Check member-only restrictions
-  if (event.membersOnly && !user.member) {
+  if (event.membersOnly && !hasMemberAccess(user.member)) {
     return {
       valid: false,
       reason: "This event is for members only. Please join to register.",
@@ -387,6 +399,9 @@ export const formatPrice = (price, currency = "CAD") => {
  * @returns {Object} { ticketType, price, currency, isEarlyBird }
  */
 export const calculateSeriesTicketPrice = (series, member = null) => {
+  // Members without access (guest/suspended/cancelled) get public pricing only.
+  const accessMember = hasMemberAccess(member) ? member : null;
+
   if (!series.tickets?.enabled) {
     return {
       ticketType: "guest",
@@ -400,14 +415,14 @@ export const calculateSeriesTicketPrice = (series, member = null) => {
   const now = new Date();
 
   // Member pricing
-  if (member && series.tickets.member?.available) {
+  if (accessMember && series.tickets.member?.available) {
     const memberTicket = series.tickets.member;
     let price = memberTicket.price || 0;
     let isFree = memberTicket.isFree;
 
     // Check for circle-specific overrides
-    if (memberTicket.circleOverrides && member.circle) {
-      const circleOverride = memberTicket.circleOverrides[member.circle];
+    if (memberTicket.circleOverrides && accessMember.circle) {
+      const circleOverride = memberTicket.circleOverrides[accessMember.circle];
       if (circleOverride) {
         if (circleOverride.isFree !== undefined) {
           isFree = circleOverride.isFree;