From 039a6802e34cfdbc546f3a7dfa9440ddbd7dab95 Mon Sep 17 00:00:00 2001
From: Jennie Robinson Faber <jennie@jenniefaber.com>
Date: Sun, 24 May 2026 00:43:54 +0100
Subject: [PATCH] =?UTF-8?q?fix(e2e):=20repair=20failing=20suite=20?=
 =?UTF-8?q?=E2=80=94=20a11y=20fixes=20and=20stale=20assertions?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Three product a11y defects: drop role="radiogroup" from the /join PWYC
<ul> (it stripped the list role; native radios already group), use
--parch-text on the active contribution chip (was --text-bright, 1.17:1
on --parch), and label the New tag pool USelect on event create.

Three stale tests: real event-type filter labels, updated location
placeholder, and click the label instead of the hidden 0×0 radio.
---
 app/components/ContributionAmountField.vue | 2 +-
 app/pages/admin/events/create.vue          | 1 +
 app/pages/join.vue                         | 1 -
 e2e/admin-events.spec.js                   | 2 +-
 e2e/events.spec.js                         | 4 ++--
 e2e/join-flow.spec.js                      | 4 ++--
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/app/components/ContributionAmountField.vue b/app/components/ContributionAmountField.vue
index b8a331a..ffc596c 100644
--- a/app/components/ContributionAmountField.vue
+++ b/app/components/ContributionAmountField.vue
@@ -261,7 +261,7 @@ const onCadenceChange = (newCadence) => {
   border-style: solid;
   border-color: var(--candle);
   background: var(--parch);
-  color: var(--text-bright);
+  color: var(--parch-text);
 }
 
 .contribution-guidance {
diff --git a/app/pages/admin/events/create.vue b/app/pages/admin/events/create.vue
index b388e9b..d5625a2 100644
--- a/app/pages/admin/events/create.vue
+++ b/app/pages/admin/events/create.vue
@@ -350,6 +350,7 @@
               <label>New tag pool</label>
               <USelect
                 v-model="newTagPool"
+                aria-label="New tag pool"
                 :items="[
                   { label: 'Cooperative', value: 'cooperative' },
                   { label: 'Craft', value: 'craft' },
diff --git a/app/pages/join.vue b/app/pages/join.vue
index 2ba29de..e2032f0 100644
--- a/app/pages/join.vue
+++ b/app/pages/join.vue
@@ -153,7 +153,6 @@
 
                 <ul
                   class="pwyc-list"
-                  role="radiogroup"
                   aria-label="Contribution amount"
                 >
                   <li
diff --git a/e2e/admin-events.spec.js b/e2e/admin-events.spec.js
index 4acd617..23de796 100644
--- a/e2e/admin-events.spec.js
+++ b/e2e/admin-events.spec.js
@@ -88,7 +88,7 @@ test.describe('Admin events CRUD', () => {
       .fill('e2e test event description')
 
     await adminPage
-      .getByPlaceholder('e.g., https://zoom.us/j/123... or #channel-name')
+      .getByPlaceholder('e.g., https://zoom.us/j/123..., #channel-name, or TBD')
       .fill('https://example.com/zoom')
 
     const startInput = adminPage.getByPlaceholder(
diff --git a/e2e/events.spec.js b/e2e/events.spec.js
index 3453fdd..a1a11fe 100644
--- a/e2e/events.spec.js
+++ b/e2e/events.spec.js
@@ -11,7 +11,7 @@ test.describe('Events list page', () => {
     const filterBar = page.locator('.filter-bar')
     await expect(filterBar).toBeVisible()
 
-    for (const label of ['All', 'Workshops', 'Community', 'Social', 'Showcase']) {
+    for (const label of ['All', 'Talk / Presentation', 'Workshop', 'Community Meetup', 'Co-working Session', 'Peer Session', 'Skills Share', 'Info Session']) {
       await expect(filterBar.locator('button', { hasText: label })).toBeVisible()
     }
   })
@@ -36,7 +36,7 @@ test.describe('Events list page', () => {
     // Wait for Vue hydration — the "All" filter should have the active class once reactive
     const allBtn = page.locator('.filter-btn', { hasText: 'All' })
     await expect(allBtn).toHaveClass(/active/, { timeout: 10000 })
-    const workshopsBtn = page.locator('.filter-bar button', { hasText: 'Workshops' })
+    const workshopsBtn = page.locator('.filter-bar button', { hasText: 'Workshop' })
     await workshopsBtn.click()
     await expect(workshopsBtn).toHaveClass(/active/, { timeout: 5000 })
   })
diff --git a/e2e/join-flow.spec.js b/e2e/join-flow.spec.js
index 3af8ea1..ba4713d 100644
--- a/e2e/join-flow.spec.js
+++ b/e2e/join-flow.spec.js
@@ -84,7 +84,7 @@ test.describe('Join page — member signup flow', () => {
     await page.locator('#join-name').fill('E2E Test User')
     await page.locator('#join-email').fill(uniqueEmail)
     // Pick the $0 preset
-    await page.locator('#pwyc-0').check({ force: true })
+    await page.locator('label[for="pwyc-0"]').click()
     await page.getByRole('checkbox', { name: /Community Guidelines/ }).check()
 
     await expect(page.locator('.submit-btn')).toBeEnabled()
@@ -191,7 +191,7 @@ test.describe('Join page — member signup flow', () => {
 
     await page.locator('#join-name').fill('Dup Test User')
     await page.locator('#join-email').fill(duplicateEmail)
-    await page.locator('#pwyc-0').check({ force: true })
+    await page.locator('label[for="pwyc-0"]').click()
     await page.getByRole('checkbox', { name: /Community Guidelines/ }).check()
     await page.locator('.submit-btn').click()